incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject Re: Review Request: Another batch of unit tests for the api project
Date Tue, 23 Oct 2012 13:11:45 GMT
This has been pushed up to the ASF repo.

Mani / Yichi, the test aren't running correctly right now.  I think it
has something to do with the version of junit that maven is using.

When I execute this (from the top level dir):  mvn test

I get lots of these errors:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
(default-compile) on project cloud-api: Compilation failure:
Compilation failure:
[ERROR] /Users/chip.childers/incubator-cloudstack/api/src/test/java/com/cloud/agent/api/AnswerTest.java:[20,23]
package org.junit does not exist

-chip


On Tue, Oct 23, 2012 at 7:20 AM, Chip Childers
<chip.childers@sungard.com> wrote:
> Mani,
>
> I have it staged locally, and will push it to the junit-tests branch
> later this morning.
>
> - chip
>
> Sent from my iPhone.
>
> On Oct 23, 2012, at 6:34 AM, Manikanta Kattamuri
> <manikanta.kattamuri@sungard.com> wrote:
>
>> Can anyone review this and close it, I feel the present unittest folder
>> structure is not testable and is orthodox to maven policies as it is defined
>> as an independent project inside api project.
>>
>> Manikanta.
>>
>> -----Original Message-----
>> From: Yichi Lu [mailto:noreply@reviews.apache.org] On Behalf Of Yichi Lu
>> Sent: Thursday, October 04, 2012 2:09 AM
>> To: cloudstack; Yichi Lu
>> Subject: Re: Review Request: Another batch of unit tests for the api project
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/7427/
>> -----------------------------------------------------------
>>
>> (Updated Oct. 3, 2012, 8:39 p.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Changes
>> -------
>>
>> uploaded two patch files.
>>
>>
>> Description
>> -------
>>
>> another batch of junit tests for the api project. Also changed test
>> directory from api/unittest to api/src/test.
>>
>>
>> Diffs (updated)
>> -----
>>
>>  api/src/test/.gitignore PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/.gitignore PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/AgentControlAnswerTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/AgentControlCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/AnswerTest.java PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/AttachIsoCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/AttachVolumeAnswerTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/AttachVolumeCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/BackupSnapshotAnswerTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/BackupSnapshotCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/BackupSnapshotCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/BackupSnapshotCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/BackupSnapshotCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/BumpUpPriorityCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/CancelCommandTest.java PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/ChangeAgentAnswerTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/ChangeAgentCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/CheckHealthAnswerTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/CheckHealthCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/CheckNetworkAnswerTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/CheckNetworkCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/CheckOnHostCommandTest.java
>> PRE-CREATION
>>  api/src/test/java/com/cloud/agent/api/CheckOnHostCommandTest.java 8960aa0
>>  api/src/test/java/com/cloud/agent/api/SnapshotCommandTest.java
>> PRE-CREATION
>>  api/src/test/pom.xml PRE-CREATION
>>  api/unittest/.gitignore eb5a316
>>  api/unittest/pom.xml 8774191
>>  api/unittest/src/com/cloud/agent/api/.gitignore 991a3b6
>>  api/unittest/src/com/cloud/agent/api/AgentControlAnswerTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/AgentControlAnswerTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/AgentControlAnswerTest.java 7bfd776
>>  api/unittest/src/com/cloud/agent/api/AgentControlCommandTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/AgentControlCommandTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/AgentControlCommandTest.java 12ea0d6
>>  api/unittest/src/com/cloud/agent/api/AnswerTest.java PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/AnswerTest.java PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/AnswerTest.java c53c84a
>>  api/unittest/src/com/cloud/agent/api/AttachIsoCommandTest.java 638ae29
>>  api/unittest/src/com/cloud/agent/api/AttachIsoCommandTest.java 638ae29
>>  api/unittest/src/com/cloud/agent/api/AttachIsoCommandTest.java 42df9db
>>  api/unittest/src/com/cloud/agent/api/AttachVolumeAnswerTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/AttachVolumeAnswerTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/AttachVolumeAnswerTest.java 886995e
>>  api/unittest/src/com/cloud/agent/api/AttachVolumeCommandTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/AttachVolumeCommandTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/AttachVolumeCommandTest.java 24e1a51
>>  api/unittest/src/com/cloud/agent/api/BackupSnapshotAnswerTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/BackupSnapshotAnswerTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/BackupSnapshotAnswerTest.java 6c6929f
>>  api/unittest/src/com/cloud/agent/api/BackupSnapshotCommandTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/BackupSnapshotCommandTest.java
>> PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/BackupSnapshotCommandTest.java
>> 3328440
>>  api/unittest/src/com/cloud/agent/api/SnapshotCommandTest.java PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/SnapshotCommandTest.java PRE-CREATION
>>  api/unittest/src/com/cloud/agent/api/SnapshotCommandTest.java 5bb412e
>>
>> Diff: https://reviews.apache.org/r/7427/diff/
>>
>>
>> Testing
>> -------
>>
>> USLT-205731:junit-tests yichi.lu$ cd api/src/test USLT-205731:test yichi.lu$
>> mvn test [INFO] Scanning for projects...
>> [INFO]
>> [INFO] ------------------------------------------------------------------------
>> [INFO] Building Apache CloudStack API Unittest 4.0.0-SNAPSHOT
>> [INFO] ------------------------------------------------------------------------
>> [INFO]
>> [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @
>> cloud-api-test --- [debug] execute contextualize [INFO] Using 'UTF-8'
>> encoding to copy filtered resources.
>> [INFO] skip non existing resourceDirectory
>> /Users/yichi.lu/CloudStack/junit-tests/api/src/test/src/main/resources
>> [INFO]
>> [INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @
>> cloud-api-test --- [INFO] Compiling 221 source files to
>> /Users/yichi.lu/CloudStack/junit-tests/api/src/test/target/classes
>> [INFO]
>> [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources)
>> @ cloud-api-test --- [debug] execute contextualize [INFO] Using 'UTF-8'
>> encoding to copy filtered resources.
>> [INFO] skip non existing resourceDirectory
>> /Users/yichi.lu/CloudStack/junit-tests/api/src/test/target/test-classes
>> [INFO]
>> [INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @
>> cloud-api-test --- [INFO] Compiling 18 source files to
>> /Users/yichi.lu/CloudStack/junit-tests/api/src/test/java/com/cloud/agent/api
>> [INFO]
>> [INFO] --- maven-surefire-plugin:2.10:test (default-test) @
>> cloud-api-test --- [INFO] Surefire report directory:
>> /Users/yichi.lu/CloudStack/junit-tests/api/src/test/target/surefire-reports
>>
>> -------------------------------------------------------
>> T E S T S
>> -------------------------------------------------------
>> Running com.cloud.agent.api.AgentControlAnswerTest
>> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.095 sec
>> Running com.cloud.agent.api.AgentControlCommandTest
>> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
>> Running com.cloud.agent.api.AnswerTest Tests run: 4, Failures: 0, Errors: 0,
>> Skipped: 0, Time elapsed: 0.003 sec Running
>> com.cloud.agent.api.AttachIsoCommandTest
>> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec
>> Running com.cloud.agent.api.AttachVolumeAnswerTest
>> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
>> Running com.cloud.agent.api.AttachVolumeCommandTest
>> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
>> Running com.cloud.agent.api.BackupSnapshotAnswerTest
>> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
>> Running com.cloud.agent.api.BackupSnapshotCommandTest
>> Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 sec
>> Running com.cloud.agent.api.BumpUpPriorityCommandTest
>> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec
>> Running com.cloud.agent.api.CancelCommandTest
>> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
>> Running com.cloud.agent.api.ChangeAgentAnswerTest
>> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
>> Running com.cloud.agent.api.ChangeAgentCommandTest
>> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
>> Running com.cloud.agent.api.CheckHealthAnswerTest
>> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec
>> Running com.cloud.agent.api.CheckHealthCommandTest
>> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec
>> Running com.cloud.agent.api.CheckNetworkAnswerTest
>> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec
>> Running com.cloud.agent.api.CheckNetworkCommandTest
>> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
>> Running com.cloud.agent.api.CheckOnHostCommandTest
>> Tests run: 41, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec
>> Running com.cloud.agent.api.SnapshotCommandTest
>> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
>>
>> Results :
>>
>> Tests run: 116, Failures: 0, Errors: 0, Skipped: 0
>>
>> [INFO] ------------------------------------------------------------------------
>> [INFO] BUILD SUCCESS
>> [INFO] ------------------------------------------------------------------------
>> [INFO] Total time: 5.784s
>> [INFO] Finished at: Wed Oct 03 15:16:48 CDT 2012 [INFO] Final Memory:
>> 12M/554M
>> [INFO] ------------------------------------------------------------------------
>>
>>
>> Thanks,
>>
>> Yichi Lu
>>

Mime
View raw message