incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hugo Trippaers <HTrippa...@schubergphilis.com>
Subject Fix for Fixing CLOUDSTACK-226 breaks deployment of physical networks without VLAN ranges
Date Fri, 05 Oct 2012 21:41:24 GMT
Hey Alena,

I just ran into a problem where the fix you pushed on for CLOUDSTACK-226 (commit 11fe086adab8e790018343252ed08aac9a27b1c6)
breaks a typical deployment scenario for Nicira based networks. A Nicira NVP user does not
need vlans so should use the vlan range item during the setup of the physical network. With
your fix this causes a NPE.

I've filed two bugs for this:
CLOUDSTACK-270 Ui should not ask for a vlan range if the physical network isolation type is
not VLAN<https://issues.apache.org/jira/browse/CLOUDSTACK-270>
CLOUDSTACK-271 updatePhysicalNetwork dies with an NPE when the vlan range is empty<https://issues.apache.org/jira/browse/CLOUDSTACK-271>

I'll pick them up and fix them, but I think it's good to be aware that any vlan code should
only run if vlans are actually in use.

Cheers!

Hugo




Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message