incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ilya musayev (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CLOUDSTACK-351) cloud-set-guest-password.in - include double quotes for variable check when using -n in bash
Date Mon, 15 Oct 2012 20:17:04 GMT

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

ilya musayev resolved CLOUDSTACK-351.
-------------------------------------

    Resolution: Fixed

diff --git a/setup/bindir/cloud-set-guest-password.in b/setup/bindir/cloud-set-guest-password.in
index 97e6e3d..69be175 100755
--- a/setup/bindir/cloud-set-guest-password.in
+++ b/setup/bindir/cloud-set-guest-password.in
@@ -39,7 +39,7 @@ do
 		file_count=$((file_count+1))
 		PASSWORD_SERVER_IP=$(grep dhcp-server-identifier $DHCP_FILE | tail -1 | awk '{print $NF}'
| tr -d '\;')
 
-		if [ -n $PASSWORD_SERVER_IP ]
+		if [ -n "$PASSWORD_SERVER_IP" ]
 		then
 			logger -t "cloud" "Found password server IP $PASSWORD_SERVER_IP in $DHCP_FILE"
 			logger -t "cloud" "Sending request to password server at $PASSWORD_SERVER_IP"
-- 
1.7.1

                
> cloud-set-guest-password.in - include double quotes for variable check when using -n
in bash
> --------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-351
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-351
>             Project: CloudStack
>          Issue Type: Bug
>          Components: Usage
>    Affects Versions: 4.0.0
>         Environment: RHEL/CENTOS 5.x/6.x and CS 3.x+/4.x+ 
>            Reporter: ilya musayev
>            Priority: Minor
>              Labels: patch
>             Fix For: 4.0.0
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> include double quotes for variable check when using -n in bash - fixes one of issue when
variable is present but not seen by bash

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message