incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Huang" <alex.hu...@citrix.com>
Subject Re: Review Request: Handle self-managed db connection correctly
Date Wed, 24 Oct 2012 19:00:33 GMT


> On Oct. 24, 2012, 6:59 p.m., Alex Huang wrote:
> > The following changes need to be made.
> > 
> > - All debug() calls should be wrapped by isDebugEnabled() checks to prevent unnecessary
string concatenation
> > - Not sure if there's any point in printing a debug log that says serializing to
json.  Please justify.
> > - The log for closing db connection should come before the actual close.

Also.  Please write unit test for the fix.

Testing is done locally is not sufficient.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7726/#review12717
-----------------------------------------------------------


On Oct. 24, 2012, 6:56 p.m., Min Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7726/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2012, 6:56 p.m.)
> 
> 
> Review request for cloudstack and Alex Huang.
> 
> 
> Description
> -------
> 
> This patch is to fix this bug https://issues.apache.org/jira/browse/CLOUDSTACK-409
> 
> 
> This addresses bug CLOUDSTACK-409.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiServlet.java 8a1d4de 
>   server/src/com/cloud/api/response/ApiResponseSerializer.java 1429d14 
>   utils/src/com/cloud/utils/db/Transaction.java bcf7ae1 
> 
> Diff: https://reviews.apache.org/r/7726/diff/
> 
> 
> Testing
> -------
> 
> Testing is done locally.
> 
> 
> Thanks,
> 
> Min Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message