incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay Venkatachalam" <>
Subject Re: Review Request: Supporting network element independent counter parameters for AutoScale.
Date Mon, 08 Oct 2012 11:20:57 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 8, 2012, 11:20 a.m.)

Review request for cloudstack and Chiradeep Vittal.


Removed the extra spaces introduced in NetUtils and added the that got
missed out in the interim diff.

Apologies for the 2 diffs.


1. The autoscale counters capabilities are passed from NetworkElement layer to the service
layers using json (i have piggy backed on lb stickiness policies). This enables validation
checks, for ex. snmpcommunity is a mandatory parameter, so if user does not pass it, the service
layer throws an error.
2. I have set the db length of the consolidated counter_params field to 1024.

I am OFF on long vacation. Will check for comments once I come back on 5th of October.

This addresses bug CS-16209.

Diffs (updated)

  api/src/com/cloud/agent/api/to/ 24ea702 
  api/src/com/cloud/api/ 4d84f3c 
  api/src/com/cloud/api/commands/ f5b21a8 
  api/src/com/cloud/api/commands/ c613a34 
  api/src/com/cloud/api/response/ 842fa3a 
  api/src/com/cloud/network/as/ PRE-CREATION 
  api/src/com/cloud/network/as/ 7fc6191 
  plugins/network-elements/netscaler/src/com/cloud/network/element/ 49c3b08

  server/src/com/cloud/api/ 4e5ee43 
  server/src/com/cloud/network/as/ b536b0b 
  server/src/com/cloud/network/as/ d963eef 
  server/src/com/cloud/network/lb/ 03b2181 
  setup/db/create-schema.sql 020c0ab 
  utils/src/com/cloud/utils/net/ 39853f4 



1. Create autoscale vm profile with new format for parameters 
   Ex. command=createAutoScaleVmProfile&...&counterparam[0].name=snmpcommunity&counterparam[0].value=public1&counterparam[1].name=snmpport&counterparam[1].value=123.
2. Update autoscale vm profile with new format
3. Create AutoScale config with the profile created in "Step 1".


Vijay Venkatachalam

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message