incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <rohit.ya...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-84: FIX NPE error in listRouter etc. after deleting a user project.
Date Sat, 06 Oct 2012 16:42:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7168/#review12205
-----------------------------------------------------------


Abhinav suggests on the issue the deleting VR still fails.
This is expected as the commit e1dc0024ea5d869dd9945b920ba85dd2a24a51c1 only fixes issues
on the API layer.
The deletion fails on ACL. Please see diff again on this review and let's work out a solution.

- Rohit Yadav


On Sept. 19, 2012, 3:38 p.m., Rohit Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7168/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 3:38 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, Nitin Mehta, Alena
Prokharchyk, and Alex Huang.
> 
> 
> Description
> -------
> 
> Domain ACL information should be valid even if account entry is marked
> removed. Patch fixes how account is obtained based on accountId, it
> finds among those entries which are marked deleted.
> 
> In case of project deletion, the project is marked removed first and
> then each of its elements are cleared/cleaned/deleted. While deleting
> network and router it failed because ACL only checks accounts which are
> not marked deleted.
> 
> Download original patch and git am <patch>: http://patchbin.baagi.org/p?id=40pdym
> 
> 
> This addresses bug CLOUDSTACK-84.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/acl/DomainChecker.java 6bc2cd3 
>   server/src/com/cloud/user/dao/AccountDao.java 3b7fa66 
>   server/src/com/cloud/user/dao/AccountDaoImpl.java 7300bb1 
> 
> Diff: https://reviews.apache.org/r/7168/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohit Yadav
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message