incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devdeep Singh" <devdeep.si...@citrix.com>
Subject Re: Review Request: Supporting network element independent counter parameters for AutoScale.
Date Fri, 05 Oct 2012 12:34:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7328/#review12191
-----------------------------------------------------------



api/src/com/cloud/api/response/AutoScaleVmProfileResponse.java
<https://reviews.apache.org/r/7328/#comment25873>

    Looks like there is a trailing white space here.



api/src/com/cloud/network/as/AutoScaleCounter.java
<https://reviews.apache.org/r/7328/#comment25874>

    Apache license please



plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
<https://reviews.apache.org/r/7328/#comment25875>

    Is it possible to reuse the Gson object?



server/src/com/cloud/network/as/AutoScaleManagerImpl.java
<https://reviews.apache.org/r/7328/#comment25876>

    Should we break at end of if, if counter is matched?



utils/src/com/cloud/utils/net/NetUtils.java
<https://reviews.apache.org/r/7328/#comment25877>

    trailing space?


- Devdeep Singh


On Sept. 27, 2012, 5:26 p.m., Vijay Venkatachalam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7328/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2012, 5:26 p.m.)
> 
> 
> Review request for cloudstack and Chiradeep Vittal.
> 
> 
> Description
> -------
> 
> 1. The autoscale counters capabilities are passed from NetworkElement layer to the service
layers using json (i have piggy backed on lb stickiness policies). This enables validation
checks, for ex. snmpcommunity is a mandatory parameter, so if user does not pass it, the service
layer throws an error.
> 2. I have set the db length of the consolidated counter_params field to 1024.
> 
> PS:
> I am OFF on long vacation. Will check for comments once I come back on 5th of October.
> 
> 
> This addresses bug CS-16209.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/agent/api/to/LoadBalancerTO.java 24ea702 
>   api/src/com/cloud/api/ApiConstants.java 4d84f3c 
>   api/src/com/cloud/api/commands/CreateAutoScaleVmProfileCmd.java f5b21a8 
>   api/src/com/cloud/api/commands/UpdateAutoScaleVmProfileCmd.java c613a34 
>   api/src/com/cloud/api/response/AutoScaleVmProfileResponse.java 842fa3a 
>   api/src/com/cloud/network/as/AutoScaleCounter.java PRE-CREATION 
>   api/src/com/cloud/network/as/AutoScaleVmProfile.java 7fc6191 
>   plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
49c3b08 
>   plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
9900e01 
>   server/src/com/cloud/api/ApiResponseHelper.java 4e5ee43 
>   server/src/com/cloud/network/as/AutoScaleManagerImpl.java b536b0b 
>   server/src/com/cloud/network/as/AutoScaleVmProfileVO.java d963eef 
>   server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 03b2181 
>   setup/db/create-schema.sql 020c0ab 
>   utils/src/com/cloud/utils/net/NetUtils.java 39853f4 
> 
> Diff: https://reviews.apache.org/r/7328/diff/
> 
> 
> Testing
> -------
> 
> 1. Create autoscale vm profile with new format for parameters 
>    Ex. command=createAutoScaleVmProfile&...&counterparam[0].name=snmpcommunity&counterparam[0].value=public1&counterparam[1].name=snmpport&counterparam[1].value=123.
> 2. Update autoscale vm profile with new format
> 3. Create AutoScale config with the profile created in "Step 1".
> 
> 
> Thanks,
> 
> Vijay Venkatachalam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message