Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============1373675441989043892=="
MIME-Version: 1.0
Subject: Re: Review Request: doc files for inter vlan routing
From: "Jessica Tomechak" <jessica.tomechak@gmail.com>
To: "David Nalley" <david@gnsa.us>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Radhika PC" <radhika.puthiyetath@citrix.com>,
 "Jessica Tomechak" <jessica.tomechak@gmail.com>
Date: Thu, 27 Sep 2012 18:56:58 -0000
Message-ID: <20120927185658.18994.66591@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jessica Tomechak" <noreply@reviews.apache.org>
References: <20120927064946.18994.62790@reviews.apache.org>
In-Reply-To: <20120927064946.18994.62790@reviews.apache.org>
Reply-To: "Jessica Tomechak" <jessica.tomechak@gmail.com>

--===============1373675441989043892==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On Sept. 27, 2012, 6:49 a.m., Jessica Tomechak wrote:
> > Some of the image file names don't match the introductory text, which m=
akes me wonder whether it's the correct image file. It might be, if the sam=
e file is being reused for different tasks. Minor issue: some of the alt te=
xts don't match the image file names.
> =

> Radhika PC wrote:
>     Do you prefer to add multiple copies of the same image with diff name=
s, or what currently followed is fine ?

It could be argued either way. I would lean toward re-using files, to keep =
the image directory smaller. However, making appropriately named copies mak=
es the code much easier to read. It might be worth bringing up with the com=
munity.


> On Sept. 27, 2012, 6:49 a.m., Jessica Tomechak wrote:
> > docs/en-US/delete-reset-vpn.xml, line 75
> > <https://reviews.apache.org/r/7106/diff/1/?file=3D155074#file155074line=
75>
> >
> >     This alt text doesn't match the .png filename.
> =

> Radhika PC wrote:
>     this is a correct image file. same file has been reused for diff tasks

The actual file name at the start of the phrase, RemoveVPN.png, doesn't mat=
ch the file name in the imagedata tag above it. The file names should match=
, as that's part of the purpose of the alt text. Even for our own use, it's=
 very helpful in debugging missing image files. =


Actually, most of the file names in alt texts throughout these files don't =
match *exactly,* but I only flagged the ones where the name was radically d=
ifferent. It would be great to fix them all to be verbatim copies of the ac=
tual file names.

Sorry I was not clear enough about what was not matching.


> On Sept. 27, 2012, 6:49 a.m., Jessica Tomechak wrote:
> > docs/en-US/release-ip-for-vpc.xml, line 72
> > <https://reviews.apache.org/r/7106/diff/1/?file=3D155077#file155077line=
72>
> >
> >     Shouldn't this refer to release-ip-icon.png?
> =

> Radhika PC wrote:
>     this is a correct image file. same file has been reused for diff tasks

Then we can delete release-ip-icon.png, since it is just a renamed duplicat=
e of destroy-instance.png.


> On Sept. 27, 2012, 6:49 a.m., Jessica Tomechak wrote:
> > docs/en-US/delete-reset-vpn.xml, line 84
> > <https://reviews.apache.org/r/7106/diff/1/?file=3D155074#file155074line=
84>
> >
> >     This alt text doesn't match the .png file name.
> =

> Radhika PC wrote:
>     this is a correct image file. same file has been reused for diff tasks


- Jessica


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7106/#review11968
-----------------------------------------------------------


On Sept. 14, 2012, 12:36 p.m., Radhika PC wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7106/
> -----------------------------------------------------------
> =

> (Updated Sept. 14, 2012, 12:36 p.m.)
> =

> =

> Review request for cloudstack and David Nalley.
> =

> =

> Description
> -------
> =

> files for VPC/inter vlan routing
> =

> =

> Diffs
> -----
> =

>   docs/en-US/acquire-new-ip-for-vpc.xml PRE-CREATION =

>   docs/en-US/add-gateway-vpc.xml PRE-CREATION =

>   docs/en-US/add-loadbalancer-rule-vpc.xml PRE-CREATION =

>   docs/en-US/add-portforward-rule-vpc.xml PRE-CREATION =

>   docs/en-US/add-tier.xml PRE-CREATION =

>   docs/en-US/add-vm-to-tier.xml PRE-CREATION =

>   docs/en-US/add-vpc.xml PRE-CREATION =

>   docs/en-US/configure-acl.xml PRE-CREATION =

>   docs/en-US/configure-vpc.xml PRE-CREATION =

>   docs/en-US/delete-reset-vpn.xml PRE-CREATION =

>   docs/en-US/enable-disable-static-nat-vpc.xml PRE-CREATION =

>   docs/en-US/inter-vlan-routing.xml PRE-CREATION =

>   docs/en-US/release-ip-for-vpc.xml PRE-CREATION =

>   docs/en-US/remove-tier.xml PRE-CREATION =

>   docs/en-US/remove-vpc.xml PRE-CREATION =

> =

> Diff: https://reviews.apache.org/r/7106/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Radhika PC
> =

>


--===============1373675441989043892==--