Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7E494DAA8 for ; Wed, 26 Sep 2012 04:08:04 +0000 (UTC) Received: (qmail 75808 invoked by uid 500); 26 Sep 2012 04:08:04 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 75647 invoked by uid 500); 26 Sep 2012 04:08:03 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 75596 invoked by uid 99); 26 Sep 2012 04:08:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2012 04:08:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 43DD51C437E; Wed, 26 Sep 2012 04:08:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8512231225535638824==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in From: "Rohit Yadav" To: "Alex Huang" , "Abhinandan Prateek" , "Alena Prokharchyk" Cc: "cloudstack" , "Rohit Yadav" Date: Wed, 26 Sep 2012 04:07:59 -0000 Message-ID: <20120926040759.18994.72665@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/7130/ X-Sender: "Rohit Yadav" References: <20120925205140.18991.81746@reviews.apache.org> In-Reply-To: <20120925205140.18991.81746@reviews.apache.org> Reply-To: "Rohit Yadav" --===============8512231225535638824== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Sept. 25, 2012, 8:51 p.m., Alena Prokharchyk wrote: > > Could you also please add warn log statement on the case when account c= an't be found? At the moment we just return NULL. Already added. Please check the diff code. When authenticated boolean is True, it checks for number of things and retu= rns the userAccount, otherwise it falls into the else{} block where it upda= tes the incorrect login attempt on the user, and if user=3D=3Dnull (the els= e inside this else) we log saying; s_logger.debug("Authentication failure: No user with name " + username + " = for domainId " + domainId); We return null in this else{} block as the authenticated was false. - Rohit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7130/#review11907 ----------------------------------------------------------- On Sept. 25, 2012, 7:56 a.m., Rohit Yadav wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7130/ > ----------------------------------------------------------- > = > (Updated Sept. 25, 2012, 7:56 a.m.) > = > = > Review request for cloudstack, Abhinandan Prateek, Alena Prokharchyk, and= Alex Huang. > = > = > Description > ------- > = > Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-121 > = > Download original patch and git am : > http://bhaisaab.org/patches/cloudstack/0001-CLOUDSTACK-121-Fix-NullPointe= rException-for-incorrec.patch > = > = > Diffs > ----- > = > api/src/com/cloud/user/UserAccount.java 734e16b = > server/src/com/cloud/user/AccountManagerImpl.java fa9fafb = > = > Diff: https://reviews.apache.org/r/7130/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Rohit Yadav > = > --===============8512231225535638824==--