Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 209DBD160 for ; Tue, 25 Sep 2012 22:43:06 +0000 (UTC) Received: (qmail 45368 invoked by uid 500); 25 Sep 2012 22:43:05 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 45326 invoked by uid 500); 25 Sep 2012 22:43:05 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 45312 invoked by uid 99); 25 Sep 2012 22:43:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2012 22:43:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4D9071C4329; Tue, 25 Sep 2012 22:43:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5204296644387975159==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-196: cloud-set-guest-password enhancement to support Debian (and derivatives) From: "edison su" To: "cloudstack" , "edison su" , "Matty Courtney" Date: Tue, 25 Sep 2012 22:43:04 -0000 Message-ID: <20120925224304.18994.99231@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "edison su" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/7243/ X-Sender: "edison su" References: <20120925031921.18994.3004@reviews.apache.org> In-Reply-To: <20120925031921.18994.3004@reviews.apache.org> Reply-To: "edison su" --===============5204296644387975159== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7243/#review11910 ----------------------------------------------------------- Ship it! Ship It! - edison su On Sept. 25, 2012, 3:19 a.m., Matty Courtney wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7243/ > ----------------------------------------------------------- > = > (Updated Sept. 25, 2012, 3:19 a.m.) > = > = > Review request for cloudstack. > = > = > Description > ------- > = > The passwd utility on Debian based distributions does not support the --s= tdin option. I propose updating the script located at http://cloudstack.org= /dl/cloud-set-guest-password to use the chpasswd utility instead. = > = > Additionally, Ubuntu 12.04 places DHCP lease information in /etc/dhcp/*. = I propose adding this to the search patch used when looking for the DHCP se= rver. = > = > Patch attached > = > = > This addresses bug CLOUDSTACK-196. > = > = > Diffs > ----- > = > tools/guest_password/cloud-set-guest-password 97e6e3d = > = > Diff: https://reviews.apache.org/r/7243/diff/ > = > = > Testing > ------- > = > Tested amended script on Redhat and Debian based distributions and confir= med password is changed as and when expected > = > = > Thanks, > = > Matty Courtney > = > --===============5204296644387975159==--