Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3EFD1DD81 for ; Mon, 24 Sep 2012 18:26:16 +0000 (UTC) Received: (qmail 3990 invoked by uid 500); 24 Sep 2012 18:26:16 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 3943 invoked by uid 500); 24 Sep 2012 18:26:15 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 3924 invoked by uid 99); 24 Sep 2012 18:26:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Sep 2012 18:26:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8AC901C0A3D; Mon, 24 Sep 2012 18:26:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3810054452407580938==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-84: FIX NPE error in listRouter etc. after deleting a user project. From: "Rohit Yadav" To: "Alena Prokharchyk" , "Kishan Kavala" , "Alex Huang" , "Abhinandan Prateek" , "Nitin Mehta" Cc: "Rohit Yadav" , "cloudstack" Date: Mon, 24 Sep 2012 18:26:14 -0000 Message-ID: <20120924182614.18991.69892@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/7168/ X-Sender: "Rohit Yadav" References: <20120924181204.18992.66570@reviews.apache.org> In-Reply-To: <20120924181204.18992.66570@reviews.apache.org> Reply-To: "Rohit Yadav" --===============3810054452407580938== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Sept. 24, 2012, 6:12 p.m., Alex Huang wrote: > > Does this need to go into 4.0? Yes, as per fix version on https://issues.apache.org/jira/browse/CLOUDSTACK= -84 But, whatever you advise. - Rohit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7168/#review11841 ----------------------------------------------------------- On Sept. 19, 2012, 3:38 p.m., Rohit Yadav wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7168/ > ----------------------------------------------------------- > = > (Updated Sept. 19, 2012, 3:38 p.m.) > = > = > Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, Nitin M= ehta, Alena Prokharchyk, and Alex Huang. > = > = > Description > ------- > = > Domain ACL information should be valid even if account entry is marked > removed. Patch fixes how account is obtained based on accountId, it > finds among those entries which are marked deleted. > = > In case of project deletion, the project is marked removed first and > then each of its elements are cleared/cleaned/deleted. While deleting > network and router it failed because ACL only checks accounts which are > not marked deleted. > = > Download original patch and git am : http://patchbin.baagi.org/p?i= d=3D40pdym > = > = > This addresses bug CLOUDSTACK-84. > = > = > Diffs > ----- > = > server/src/com/cloud/acl/DomainChecker.java 6bc2cd3 = > server/src/com/cloud/user/dao/AccountDao.java 3b7fa66 = > server/src/com/cloud/user/dao/AccountDaoImpl.java 7300bb1 = > = > Diff: https://reviews.apache.org/r/7168/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Rohit Yadav > = > --===============3810054452407580938==--