Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============8490537103580451380=="
MIME-Version: 1.0
Subject: Re: Review Request: CLOUDSTACK-43 : Jenkins build process needs to
 allow for
 setting the appropriate version number within the built JARs.
From: "Pradeep Soundararajan" <pradeep.soundararajan@citrix.com>
To: "Chip Childers" <chip.childers@sungard.com>,
 "edison su" <edison.su@citrix.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Rohit Yadav" <rohit.yadav@citrix.com>,
 "Pradeep Soundararajan" <pradeep.soundararajan@citrix.com>
Date: Fri, 21 Sep 2012 16:15:59 -0000
Message-ID: <20120921161559.4009.98426@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Pradeep Soundararajan" <noreply@reviews.apache.org>
References: <20120914123641.1611.19515@reviews.apache.org>
In-Reply-To: <20120914123641.1611.19515@reviews.apache.org>
Reply-To: "Pradeep Soundararajan" <pradeep.soundararajan@citrix.com>

--===============8490537103580451380==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7083/
-----------------------------------------------------------

(Updated Sept. 21, 2012, 4:15 p.m.)


Review request for cloudstack, Chip Childers and edison su.


Changes
-------

Guys, updated the patch accordingly. I am able to perform mvn and waf rpm. =
But I am getting some warnings initially, please take a look at the attache=
d logs...

/usr/lib/jvm/java
[INFO] Scanning for projects...
[WARNING] =

[WARNING] Some problems were encountered while building the effective model=
 for org.apache.cloudstack:cloud-api:jar:4.0.0
[WARNING] 'version' contains an expression but should be a constant. @ org.=
apache.cloudstack:cloudstack:${cs.version}, /var/lib/jenkins/workspace/test=
-cloudstack-4.0-rhel6.3/pom.xml, line 31, column 12
[WARNING] =

[WARNING] Some problems were encountered while building the effective model=
 for org.apache.cloudstack:cloud-awsapi:jar:4.0.0
[WARNING] 'version' contains an expression but should be a constant. @ org.=
apache.cloudstack:cloud-awsapi:${cs.version}, /var/lib/jenkins/workspace/te=
st-cloudstack-4.0-rhel6.3/awsapi/pom.xml, line 23, column 12
[WARNING] =

[WARNING] Some problems were encountered while building the effective model=
 for org.apache.cloudstack:cloudstack:pom:4.0.0
[WARNING] 'version' contains an expression but should be a constant. @ org.=
apache.cloudstack:cloudstack:${cs.version}, /var/lib/jenkins/workspace/test=
-cloudstack-4.0-rhel6.3/pom.xml, line 31, column 12
[WARNING] =

[WARNING] It is highly recommended to fix these problems because they threa=
ten the stability of your build.
[WARNING] =

[WARNING] For this reason, future Maven versions might no longer support bu=
ilding such malformed projects.
[WARNING] =

[INFO] --------------------------------------------------------------------=
----


Description
-------

The Jenkins binary build processes are producing JAR files that contain ver=
sion numbers like 4.0.0-SNAPSHOT. We need a way to set a parameter within t=
he build to set the version from SNAPSHOT to RC1 or even drop the pre-relea=
se identifier entirely (so that we can generate an actual release). =


>> Removed the occurrences of SNAPSHOT


Diffs (updated)
-----

  agent/pom.xml a559580 =

  api/pom.xml db14775 =

  awsapi/pom.xml a583384 =

  client/pom.xml 50b85e9 =

  cloud.spec c1fe56a =

  console-proxy/pom.xml 8bfb753 =

  core/pom.xml 510cb04 =

  deps/XenServerJava/pom.xml 1337514 =

  deps/pom.xml 1e20083 =

  patches/pom.xml d62fc86 =

  plugins/deployment-planners/user-concentrated-pod/pom.xml ca2fae1 =

  plugins/deployment-planners/user-dispersing/pom.xml 6e1ffc6 =

  plugins/file-systems/netapp/pom.xml f10e5a4 =

  plugins/host-allocators/random/pom.xml ad66c0e =

  plugins/hypervisors/kvm/pom.xml 4863085 =

  plugins/hypervisors/ovm/pom.xml a8b23d0 =

  plugins/hypervisors/vmware/pom.xml 435ae38 =

  plugins/hypervisors/xen/pom.xml bf38e47 =

  plugins/network-elements/elastic-loadbalancer/pom.xml c1ab2c5 =

  plugins/network-elements/f5/pom.xml 0cba48c =

  plugins/network-elements/juniper-srx/pom.xml 38a2b55 =

  plugins/network-elements/midokura-midonet/pom.xml 7f2e2d3 =

  plugins/network-elements/netscaler/pom.xml 377e6e0 =

  plugins/network-elements/nicira-nvp/pom.xml 37c3a3a =

  plugins/network-elements/ovs/pom.xml 02d455c =

  plugins/pom.xml 206d4a1 =

  plugins/storage-allocators/random/pom.xml 6cb60cd =

  plugins/user-authenticators/ldap/pom.xml 7facc3f =

  plugins/user-authenticators/md5/pom.xml 1dac92d =

  plugins/user-authenticators/plain-text/pom.xml a4280a3 =

  pom.xml 49a71a1 =

  server/pom.xml f7178d8 =

  test/pom.xml f70a89f =

  usage/pom.xml 92e5e72 =

  utils/pom.xml e8d7827 =

  vmware-base/pom.xml 1dabe83 =

  wscript_build 4264822 =


Diff: https://reviews.apache.org/r/7083/diff/


Testing
-------

Able to execute mvn install successfully after the changes...


Thanks,

Pradeep Soundararajan


--===============8490537103580451380==--