Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4158CD783 for ; Mon, 17 Sep 2012 05:08:48 +0000 (UTC) Received: (qmail 37411 invoked by uid 500); 17 Sep 2012 05:08:47 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 36881 invoked by uid 500); 17 Sep 2012 05:08:40 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 36843 invoked by uid 99); 17 Sep 2012 05:08:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Sep 2012 05:08:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8137E1C01B0; Mon, 17 Sep 2012 05:08:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1503610142858508993==" MIME-Version: 1.0 Subject: Re: Review Request: Handling of errors during AutoScaleConfig in NetScaler. From: "Devdeep Singh" To: "Devdeep Singh" Cc: "cloudstack" , "Vijay Venkatachalam" Date: Mon, 17 Sep 2012 05:08:38 -0000 Message-ID: <20120917050838.3981.53330@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Devdeep Singh" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/7058/ X-Sender: "Devdeep Singh" References: <20120914151745.1611.33180@reviews.apache.org> In-Reply-To: <20120914151745.1611.33180@reviews.apache.org> Reply-To: "Devdeep Singh" --===============1503610142858508993== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7058/#review11604 ----------------------------------------------------------- Ship it! Ship It! - Devdeep Singh On Sept. 14, 2012, 3:17 p.m., Vijay Venkatachalam wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7058/ > ----------------------------------------------------------- > = > (Updated Sept. 14, 2012, 3:17 p.m.) > = > = > Review request for cloudstack and Devdeep Singh. > = > = > Description > ------- > = > AutoScale. Added clean-up if NetScaler errors out during AutoScale config. > Also re-organized NetScalerResource to keep AutoScale block together. > = > = > This addresses bug CS-15727. > = > = > Diffs > ----- > = > plugins/network-elements/netscaler/src/com/cloud/network/resource/Netsc= alerResource.java 0d13622 = > = > Diff: https://reviews.apache.org/r/7058/diff/ > = > = > Testing > ------- > = > 1. Normal AutoScale config. > 2. Login to netscaler. Remove timer policy. > 3. Remove AutoScale VmGroup from CloudStack. > 4. NS Config should return as it was in "No 1" after the error. > = > = > Thanks, > = > Vijay Venkatachalam > = > --===============1503610142858508993==--