Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 06D55D8AD for ; Tue, 11 Sep 2012 16:11:40 +0000 (UTC) Received: (qmail 5784 invoked by uid 500); 11 Sep 2012 16:11:39 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 5753 invoked by uid 500); 11 Sep 2012 16:11:39 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 5740 invoked by uid 99); 11 Sep 2012 16:11:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Sep 2012 16:11:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BDFDC1C1F60; Tue, 11 Sep 2012 16:11:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7898768788999487142==" MIME-Version: 1.0 Subject: Re: Review Request: CS-15783: Creating mapping between job ids and autoscale entity ids From: "Pranav Saxena" To: "Deepak Garg" , "Devdeep Singh" Cc: "cloudstack" , "Vijay Venkatachalam" , "Pranav Saxena" Date: Tue, 11 Sep 2012 16:11:38 -0000 Message-ID: <20120911161138.1601.96714@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Pranav Saxena" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/6899/ X-Sender: "Pranav Saxena" References: <20120904122413.583.11981@reviews.apache.org> In-Reply-To: <20120904122413.583.11981@reviews.apache.org> Reply-To: "Pranav Saxena" --===============7898768788999487142== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6899/#review11330 ----------------------------------------------------------- Changes pushed to asf/autoscale. Please mark the ticket as "Submitted". = Thanks ! - Pranav Saxena On Sept. 4, 2012, 12:24 p.m., Vijay Venkatachalam wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6899/ > ----------------------------------------------------------- > = > (Updated Sept. 4, 2012, 12:24 p.m.) > = > = > Review request for cloudstack, Devdeep Singh and Deepak Garg. > = > = > Description > ------- > = > 1. After AutoScaleVmGroup creation, the asynchronous jobs cannot be liste= d momentarily. > This happened because there was a mapping missing between the job > instance id and autoscale vm group instance id. > Fix: Introducing the mapping between job instance id and autoscale ent= ity > instance ids. > 2. Updated JobInstance type in VmGroup commands. > 3. Removing "action" as a mandatory parameter for listAutoScalePolicies c= ommand. > = > = > This addresses bug CS-15783. > = > = > Diffs > ----- > = > api/src/com/cloud/api/commands/DeleteAutoScaleVmGroupCmd.java b97d734 = > api/src/com/cloud/api/commands/DisableAutoScaleVmGroupCmd.java fa90fff = > api/src/com/cloud/api/commands/EnableAutoScaleVmGroupCmd.java 4b4d1c3 = > api/src/com/cloud/api/commands/ListAutoScalePoliciesCmd.java 1d61641 = > api/src/com/cloud/api/response/AsyncJobResponse.java 3644595 = > = > Diff: https://reviews.apache.org/r/6899/diff/ > = > = > Testing > ------- > = > 1. Create AutoScalePolicyVmGroup through UI, the return values of query a= sync job does not return errors. > 2. Fire api request command =3D listAutoScalePolicies with id alone. = > = > = > Thanks, > = > Vijay Venkatachalam > = > --===============7898768788999487142==--