Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E5A65D788 for ; Fri, 7 Sep 2012 10:08:29 +0000 (UTC) Received: (qmail 42559 invoked by uid 500); 7 Sep 2012 10:08:29 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 42506 invoked by uid 500); 7 Sep 2012 10:08:29 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 42490 invoked by uid 99); 7 Sep 2012 10:08:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Sep 2012 10:08:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7B34A1C1D73; Fri, 7 Sep 2012 10:08:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8036442148862434945==" MIME-Version: 1.0 Subject: Re: Review Request: CS-10219 Add option to set login attempts to portal. From: "saksham srivastava" To: "Alena Prokharchyk" , "Nitin Mehta" , "Devdeep Singh" Cc: "saksham srivastava" , "Koushik Das" , "cloudstack" Date: Fri, 07 Sep 2012 10:08:28 -0000 Message-ID: <20120907100828.583.72553@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "saksham srivastava" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/6858/ X-Sender: "saksham srivastava" References: <20120907034624.582.94274@reviews.apache.org> In-Reply-To: <20120907034624.582.94274@reviews.apache.org> Reply-To: "saksham srivastava" --===============8036442148862434945== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Sept. 7, 2012, 3:46 a.m., Koushik Das wrote: > > server/src/com/cloud/user/AccountManagerImpl.java, line 1879 > > > > > > I understand that ROOT/domain admin can only unlock but I don't see= that in the list of changes. Is there another commit for implementing that? ROOT Admin can enable any account, this functionality is already present in= API (enableUser) and UI. For Domain Admin the API is present. - saksham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6858/#review11155 ----------------------------------------------------------- On Sept. 7, 2012, 10:07 a.m., saksham srivastava wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6858/ > ----------------------------------------------------------- > = > (Updated Sept. 7, 2012, 10:07 a.m.) > = > = > Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Alena Prok= harchyk. > = > = > Description > ------- > = > Added global setting login.attempts.allowed which defines the maximum inc= orrect password attempts allowed. > Also after the maximum attempts are reached the user account is disabled. > = > = > This addresses bug CS-10219. > = > = > Diffs > ----- > = > core/src/com/cloud/user/UserAccountVO.java 5e7c018 = > server/src/com/cloud/configuration/Config.java ebcd070 = > server/src/com/cloud/configuration/ConfigurationManagerImpl.java f9da08= d = > server/src/com/cloud/user/AccountManagerImpl.java 38153f3 = > setup/db/create-schema.sql fa933e3 = > setup/db/db/schema-302to40.sql aaf23e6 = > = > Diff: https://reviews.apache.org/r/6858/diff/ > = > = > Testing > ------- > = > Verified locally. > = > = > Thanks, > = > saksham srivastava > = > --===============8036442148862434945==--