incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deepak Garg <deepak.g...@citrix.com>
Subject RE: Review Request: CS-16168 [AutoScale] : Deletion of Account doesn't delete the AutoScale LB rule
Date Tue, 04 Sep 2012 02:36:31 GMT
Can someone please review https://reviews.apache.org/r/6825/ ?


Thanks
Deepak


-----Original Message-----
From: Deepak Garg [mailto:noreply@reviews.apache.org] On Behalf Of Deepak Garg
Sent: Wednesday, August 29, 2012 1:32 PM
To: Vijay Venkatachalam; Pranav Saxena
Cc: cloudstack; Deepak Garg
Subject: Review Request: CS-16168 [AutoScale] : Deletion of Account doesn't delete the AutoScale
LB rule


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6825/
-----------------------------------------------------------

Review request for cloudstack, Pranav Saxena and Vijay Venkatachalam.


Description
-------

CS-16168
[AutoScale] : Deletion of Account doesn't delete the AutoScale LB rule
Steps 
============== 
1. Create a Domain inside the ROOT domain, and then create a user for that domain. 
2. Login to CS as that user and create an Autoscale LB rule. 
3. Let the LB rule get created and the minimum number of VM deployed. Now Delete the Account.


Observation 
============== 
1. The LB rule Doesn't get deleted (The attached VM gets deleted but the AutoScale LB rule
stays) 


This addresses bug CS-16168.


Diffs
-----

  server/src/com/cloud/network/as/AutoScaleManager.java 7ea7807 
  server/src/com/cloud/network/as/AutoScaleManagerImpl.java 8c39097 
  server/src/com/cloud/network/as/dao/AutoScalePolicyDao.java 8edfa94 
  server/src/com/cloud/network/as/dao/AutoScalePolicyDaoImpl.java 5dfe080 
  server/src/com/cloud/network/as/dao/AutoScaleVmProfileDao.java 0803571 
  server/src/com/cloud/network/as/dao/AutoScaleVmProfileDaoImpl.java 12392c3 
  server/src/com/cloud/network/as/dao/ConditionDao.java bb0f77f 
  server/src/com/cloud/network/as/dao/ConditionDaoImpl.java 338fe19 
  server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 8671151 
  server/src/com/cloud/user/AccountManagerImpl.java 0a11dc4 

Diff: https://reviews.apache.org/r/6825/diff/


Testing
-------

Manually tested on my setup.


Thanks,

Deepak Garg

Mime
View raw message