incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jessica Tomechak" <jessica.tomec...@gmail.com>
Subject Re: Review Request: doc files for inter vlan routing
Date Thu, 27 Sep 2012 18:56:58 GMT


> On Sept. 27, 2012, 6:49 a.m., Jessica Tomechak wrote:
> > Some of the image file names don't match the introductory text, which makes me wonder
whether it's the correct image file. It might be, if the same file is being reused for different
tasks. Minor issue: some of the alt texts don't match the image file names.
> 
> Radhika PC wrote:
>     Do you prefer to add multiple copies of the same image with diff names, or what currently
followed is fine ?

It could be argued either way. I would lean toward re-using files, to keep the image directory
smaller. However, making appropriately named copies makes the code much easier to read. It
might be worth bringing up with the community.


> On Sept. 27, 2012, 6:49 a.m., Jessica Tomechak wrote:
> > docs/en-US/delete-reset-vpn.xml, line 75
> > <https://reviews.apache.org/r/7106/diff/1/?file=155074#file155074line75>
> >
> >     This alt text doesn't match the .png filename.
> 
> Radhika PC wrote:
>     this is a correct image file. same file has been reused for diff tasks

The actual file name at the start of the phrase, RemoveVPN.png, doesn't match the file name
in the imagedata tag above it. The file names should match, as that's part of the purpose
of the alt text. Even for our own use, it's very helpful in debugging missing image files.


Actually, most of the file names in alt texts throughout these files don't match *exactly,*
but I only flagged the ones where the name was radically different. It would be great to fix
them all to be verbatim copies of the actual file names.

Sorry I was not clear enough about what was not matching.


> On Sept. 27, 2012, 6:49 a.m., Jessica Tomechak wrote:
> > docs/en-US/release-ip-for-vpc.xml, line 72
> > <https://reviews.apache.org/r/7106/diff/1/?file=155077#file155077line72>
> >
> >     Shouldn't this refer to release-ip-icon.png?
> 
> Radhika PC wrote:
>     this is a correct image file. same file has been reused for diff tasks

Then we can delete release-ip-icon.png, since it is just a renamed duplicate of destroy-instance.png.


> On Sept. 27, 2012, 6:49 a.m., Jessica Tomechak wrote:
> > docs/en-US/delete-reset-vpn.xml, line 84
> > <https://reviews.apache.org/r/7106/diff/1/?file=155074#file155074line84>
> >
> >     This alt text doesn't match the .png file name.
> 
> Radhika PC wrote:
>     this is a correct image file. same file has been reused for diff tasks


- Jessica


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7106/#review11968
-----------------------------------------------------------


On Sept. 14, 2012, 12:36 p.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7106/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2012, 12:36 p.m.)
> 
> 
> Review request for cloudstack and David Nalley.
> 
> 
> Description
> -------
> 
> files for VPC/inter vlan routing
> 
> 
> Diffs
> -----
> 
>   docs/en-US/acquire-new-ip-for-vpc.xml PRE-CREATION 
>   docs/en-US/add-gateway-vpc.xml PRE-CREATION 
>   docs/en-US/add-loadbalancer-rule-vpc.xml PRE-CREATION 
>   docs/en-US/add-portforward-rule-vpc.xml PRE-CREATION 
>   docs/en-US/add-tier.xml PRE-CREATION 
>   docs/en-US/add-vm-to-tier.xml PRE-CREATION 
>   docs/en-US/add-vpc.xml PRE-CREATION 
>   docs/en-US/configure-acl.xml PRE-CREATION 
>   docs/en-US/configure-vpc.xml PRE-CREATION 
>   docs/en-US/delete-reset-vpn.xml PRE-CREATION 
>   docs/en-US/enable-disable-static-nat-vpc.xml PRE-CREATION 
>   docs/en-US/inter-vlan-routing.xml PRE-CREATION 
>   docs/en-US/release-ip-for-vpc.xml PRE-CREATION 
>   docs/en-US/remove-tier.xml PRE-CREATION 
>   docs/en-US/remove-vpc.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/7106/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radhika PC
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message