incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "edison su" <edison...@citrix.com>
Subject Re: Review Request: STT isolation support for KVM
Date Thu, 27 Sep 2012 00:34:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7165/#review11960
-----------------------------------------------------------



plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
<https://reviews.apache.org/r/7165/#comment25495>

    Sorry for the late about reviewing your code. 
    I think here it's better to subclass BridgeVifDriver, as normal linux bridge doesn't this
special handling.
    For example, you can put all your modification on BridgeVifDriver into a new class called
ovsVifDriver, override plug and unplug, then in agent.properties file, add libvirt.vif.driver=ovsVifDriver.



- edison su


On Sept. 19, 2012, 11:30 a.m., Hiroaki Kawai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7165/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 11:30 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Adds STT support on KVM host, just like in XenServer. The host os having openvswitch
and brcompat kernel module will plug the VM to openvswitch port through general brctl interface
calls.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
cf4de09 
>   scripts/vm/network/vnet/setupLswitch.sh PRE-CREATION 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 242852f 
> 
> Diff: https://reviews.apache.org/r/7165/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hiroaki Kawai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message