incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mice xia" <mice_...@tcloudcomputing.com>
Subject Re: Review Request: VPC create vm from ISO template
Date Wed, 26 Sep 2012 09:09:42 GMT


> On Sept. 26, 2012, 5:40 a.m., mice xia wrote:
> > should we also consider isISO situation?  like including condition (isIso &&
!vpcSupportedHTypes.contains(hypervisor)), there is a parameter 'hypervisor' passed from API
layer.
> 
> Marcus Sorensen wrote:
>     I suppose it depends on whether the intent was to test the template to see if its
valid in VPC or to test the deployment itself. I think they both end in the same result at
this point. I just thought I'd pass this on since I already had this change being tested.
> 
> mice xia wrote:
>     it is checking if template/ISO's hypervisorType is supported by VPC.
>     your patch can pass xenserver/kvm/vmware, but suppose we are creating an OVM based
VM with VPC network and from ISO, it is supposed to throw an exception here because OVM does
not support VPC feature.
> 
> Marcus Sorensen wrote:
>     That is true. This patch fixes the template check, its either an ISO or a supported
VPC template, but if this is the only point where hypervisor validation occurs, then that
should be remedied as well.

very likely this is the only place to do the validation, please update the patch 


- mice


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7278/#review11920
-----------------------------------------------------------


On Sept. 26, 2012, 5:25 a.m., Marcus Sorensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7278/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2012, 5:25 a.m.)
> 
> 
> Review request for cloudstack and mice xia.
> 
> 
> Description
> -------
> 
> This should fix CLOUDSTACK-202.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 79eeb31 
> 
> Diff: https://reviews.apache.org/r/7278/diff/
> 
> 
> Testing
> -------
> 
> reproduced CLOUDSTACK-202, applied patch, could not reproduce issue
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message