incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <rohit.ya...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-121: FIx NullPointerException while logging in
Date Wed, 26 Sep 2012 04:07:59 GMT


> On Sept. 25, 2012, 8:51 p.m., Alena Prokharchyk wrote:
> > Could you also please add warn log statement on the case when account can't be found?
At the moment we just return NULL.

Already added. Please check the diff code.
When authenticated boolean is True, it checks for number of things and returns the userAccount,
otherwise it falls into the else{} block where it updates the incorrect login attempt on the
user, and if user==null (the else inside this else) we log saying;
s_logger.debug("Authentication failure: No user with name " + username + " for domainId "
+ domainId);
We return null in this else{} block as the authenticated was false.


- Rohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7130/#review11907
-----------------------------------------------------------


On Sept. 25, 2012, 7:56 a.m., Rohit Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7130/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2012, 7:56 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Alena Prokharchyk, and Alex Huang.
> 
> 
> Description
> -------
> 
> Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-121
> 
> Download original patch and git am <patch>:
> http://bhaisaab.org/patches/cloudstack/0001-CLOUDSTACK-121-Fix-NullPointerException-for-incorrec.patch
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/user/UserAccount.java 734e16b 
>   server/src/com/cloud/user/AccountManagerImpl.java fa9fafb 
> 
> Diff: https://reviews.apache.org/r/7130/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohit Yadav
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message