incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deepak Garg" <deepakgarg.i...@gmail.com>
Subject Review Request: CloudStack CS-15644 Pass uuid to resource layer in Autoscale instead of Ids
Date Fri, 21 Sep 2012 06:11:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7205/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh, Pranav Saxena, and Vijay Venkatachalam.


Description
-------

Ids are used instead of UUIds for entities like template, serviceoffering. Since NS will be
making api calls on MS, so its better to use UUIDs 


This addresses bug CS-15644.


Diffs
-----

  api/src/com/cloud/agent/api/to/LoadBalancerTO.java 884c7c5 
  api/src/com/cloud/network/as/AutoScaleVmGroup.java 7b882fc 
  api/src/com/cloud/network/lb/LoadBalancingRule.java 5c39f31 
  api/src/com/cloud/network/rules/LoadBalancer.java 9c67f29 
  plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java
57e631e 
  plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java 1b5f17a

  plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
f2a5278 
  server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java ba3d689 
  server/src/com/cloud/network/as/AutoScaleVmGroupVO.java 3de9f9b 
  server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 025e441 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 163252f 

Diff: https://reviews.apache.org/r/7205/diff/


Testing
-------

Manual testing on my local setup.


Thanks,

Deepak Garg


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message