incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers" <chip.child...@sungard.com>
Subject Re: Review Request: CLOUDSTACK-43 : Jenkins build process needs to allow for setting the appropriate version number within the built JARs.
Date Fri, 14 Sep 2012 13:26:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7083/#review11534
-----------------------------------------------------------


Generally, I think that all of the child projects should inherit their version from the parent
project's version.  This can be accomplished by referencing the parent version as a variable.
 I'm not a maven guy, but I looked at a few samples out there, and this appears to be the
right way to go.

However, all that being said...  Edison's comment earlier about this not actually being needed
is important. If ant is doing things correctly, then this doesn't actually matter much.  IMO,
I would like to see the maven project versions get that inheritance, so that it's already
in place for when we convert from ant build tasks to maven builds completely.

Can you make the changes I've suggested (including the note about not modifying the tomcat7
plugin version), and then resubmit the patch?

In the meantime, CLOUDSTACK-43 may be able to be closed already.

Edison, do you agree?


pom.xml
<https://reviews.apache.org/r/7083/#comment24781>

    This isn't correct, since we want to use the tomcat7 plugin as specified.


- Chip Childers


On Sept. 14, 2012, 12:36 p.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7083/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2012, 12:36 p.m.)
> 
> 
> Review request for cloudstack, Chip Childers and edison su.
> 
> 
> Description
> -------
> 
> The Jenkins binary build processes are producing JAR files that contain version numbers
like 4.0.0-SNAPSHOT. We need a way to set a parameter within the build to set the version
from SNAPSHOT to RC1 or even drop the pre-release identifier entirely (so that we can generate
an actual release). 
> 
> >> Removed the occurrences of SNAPSHOT
> 
> 
> Diffs
> -----
> 
>   agent/pom.xml a559580 
>   api/pom.xml db14775 
>   awsapi/pom.xml a583384 
>   client/pom.xml 50b85e9 
>   cloud.spec 02aa64f 
>   console-proxy/pom.xml 8bfb753 
>   core/pom.xml 510cb04 
>   deps/XenServerJava/pom.xml 1337514 
>   deps/pom.xml be30c9a 
>   patches/pom.xml d62fc86 
>   plugins/deployment-planners/user-concentrated-pod/pom.xml ca2fae1 
>   plugins/deployment-planners/user-dispersing/pom.xml 6e1ffc6 
>   plugins/file-systems/netapp/pom.xml f10e5a4 
>   plugins/host-allocators/random/pom.xml ad66c0e 
>   plugins/hypervisors/kvm/pom.xml 2d1a001 
>   plugins/hypervisors/ovm/pom.xml a8b23d0 
>   plugins/hypervisors/vmware/pom.xml 435ae38 
>   plugins/hypervisors/xen/pom.xml bf38e47 
>   plugins/network-elements/elastic-loadbalancer/pom.xml c1ab2c5 
>   plugins/network-elements/f5/pom.xml 0cba48c 
>   plugins/network-elements/juniper-srx/pom.xml 38a2b55 
>   plugins/network-elements/midokura-midonet/pom.xml 7f2e2d3 
>   plugins/network-elements/netscaler/pom.xml 377e6e0 
>   plugins/network-elements/nicira-nvp/pom.xml 37c3a3a 
>   plugins/network-elements/ovs/pom.xml 02d455c 
>   plugins/pom.xml 206d4a1 
>   plugins/storage-allocators/random/pom.xml 6cb60cd 
>   plugins/user-authenticators/ldap/pom.xml 7facc3f 
>   plugins/user-authenticators/md5/pom.xml 1dac92d 
>   plugins/user-authenticators/plain-text/pom.xml a4280a3 
>   pom.xml 972d645 
>   server/pom.xml f7178d8 
>   test/pom.xml f70a89f 
>   usage/pom.xml 92e5e72 
>   utils/pom.xml e8d7827 
>   vmware-base/pom.xml 1dabe83 
>   wscript f1c9b62 
>   wscript_build 2de698c 
> 
> Diff: https://reviews.apache.org/r/7083/diff/
> 
> 
> Testing
> -------
> 
> Able to execute mvn install successfully after the changes...
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message