incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prachi Damle" <prachi.da...@citrix.com>
Subject Re: Review Request: ec2-run-instances fails with error "Unable to find service offering by id". Component: AWSAPI.
Date Tue, 11 Sep 2012 23:54:41 GMT


> On Aug. 13, 2012, 11:33 p.m., Prachi Damle wrote:
> > Since there are changes made to DAO layer,  this patch cannot be applied as-is.
You need to apply your changes again on the work doen by Rajecsh, I guess.
> 
> Likitha Shetty wrote:
>     Changes made to the DAO layer by Rajesh have not yet been checked in to the master
so this patch can be cleanly applied right ?
> 
> Likitha Shetty wrote:
>     This issue is fixed with Rajesh's changes that moved the awsapi code from hibernate
framework to dao(commit-id 39aa7d86affccf42b2e31222fc7ad295ce7180f4). With this change, EC2Engine::getCSServiceOfferingId
now calls CloudStackSvcOfferingDaoImpl::getSvcOfferingByName which in turn uses findOneBy()
to return a service offering id. And since findOneBy() excludes the removed entities by default
the offering returned will always be a valid one.
>     
>     Prachi, is this correct ?

That's right. We dont need any change for this since DAO layer will take care of this. Please
close this ticket.


- Prachi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6425/#review10248
-----------------------------------------------------------


On Aug. 7, 2012, 5:13 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6425/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 5:13 a.m.)
> 
> 
> Review request for cloudstack and Prachi Damle.
> 
> 
> Description
> -------
> 
> Added a check in EC2Engine to verify if the service offering returned by CloudStack to
AWSAPI has not been deleted.
> 
> 
> This addresses bug CS-15771.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java 5013eac 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 1363d0d 
>   awsapi/src/com/cloud/stack/models/CloudStackServiceOffering.hbm.xml 2bbcfd1 
>   awsapi/src/com/cloud/stack/models/CloudStackServiceOffering.java 3dcf011 
> 
> Diff: https://reviews.apache.org/r/6425/diff/
> 
> 
> Testing
> -------
> 
> Created a custom compute-offering by the name 'm1.small' using the CloudStack UI, deleted
the offering and create a new one by the same name 'm1.small'../ec2-run-instances successfully
deploys a virtual machine.
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message