incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <rohit.ya...@citrix.com>
Subject Re: Review Request: Add helper for DAO based on podId
Date Tue, 11 Sep 2012 19:31:41 GMT


> On Sept. 11, 2012, 6:05 p.m., Alex Huang wrote:
> > What is this change for?

There was no method to get list of VMs  by podId, count by podId etc. The patch adds them.
They will be used in restartNetwork and may be useful elsewhere.


- Rohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7017/#review11342
-----------------------------------------------------------


On Sept. 11, 2012, 1:45 p.m., Rohit Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7017/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Murali Reddy, Alena Prokharchyk, and Alex Huang.
> 
> 
> Description
> -------
> 
> They will be used by https://reviews.apache.org/r/6781/
> 
>     Dao: Add helpers for listing based on podId
>     
>     - added listByPodId
>     - fixed listByTypeAndState to accept type and then state as arguments
>     - added listByPodIdTypeAndState in VMInstanceDao
>     - added countByPodIdVMTypeAndState in VMInstanceDao
> 
> 
> Download original patch: http://patchbin.baagi.org/p?id=ue9o0z
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/dao/DomainRouterDao.java 01e3258 
>   server/src/com/cloud/vm/dao/DomainRouterDaoImpl.java 175d3f2 
>   server/src/com/cloud/vm/dao/VMInstanceDao.java 2cf3d75 
>   server/src/com/cloud/vm/dao/VMInstanceDaoImpl.java 571b5d1 
> 
> Diff: https://reviews.apache.org/r/7017/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohit Yadav
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message