incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "saksham srivastava" <saksham.srivast...@citrix.com>
Subject Re: Review Request: CS-10219 Add option to set login attempts to portal.
Date Fri, 07 Sep 2012 10:08:28 GMT


> On Sept. 7, 2012, 3:46 a.m., Koushik Das wrote:
> > server/src/com/cloud/user/AccountManagerImpl.java, line 1879
> > <https://reviews.apache.org/r/6858/diff/5/?file=150231#file150231line1879>
> >
> >     I understand that ROOT/domain admin can only unlock but I don't see that in
the list of changes. Is there another commit for implementing that?

ROOT Admin can enable any account, this functionality is already present in API (enableUser)
and UI. For Domain Admin the API is present.


- saksham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6858/#review11155
-----------------------------------------------------------


On Sept. 7, 2012, 10:07 a.m., saksham srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6858/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2012, 10:07 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Alena Prokharchyk.
> 
> 
> Description
> -------
> 
> Added global setting login.attempts.allowed which defines the maximum incorrect password
attempts allowed.
> Also after the maximum attempts are reached the user account is disabled.
> 
> 
> This addresses bug CS-10219.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/user/UserAccountVO.java 5e7c018 
>   server/src/com/cloud/configuration/Config.java ebcd070 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java f9da08d 
>   server/src/com/cloud/user/AccountManagerImpl.java 38153f3 
>   setup/db/create-schema.sql fa933e3 
>   setup/db/db/schema-302to40.sql aaf23e6 
> 
> Diff: https://reviews.apache.org/r/6858/diff/
> 
> 
> Testing
> -------
> 
> Verified locally.
> 
> 
> Thanks,
> 
> saksham srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message