incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Huang" <alex.hu...@citrix.com>
Subject Re: Review Request: deployVirtualMachine api, added a check to see if the userdata provided is base64 encoded.
Date Thu, 06 Sep 2012 22:26:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6428/#review11142
-----------------------------------------------------------


Why not use the apache Base64.isbase64() method instead of a regex match?

- Alex Huang


On Aug. 8, 2012, 9:08 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6428/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 9:08 a.m.)
> 
> 
> Review request for cloudstack and Prachi Damle.
> 
> 
> Description
> -------
> 
> Error out with InvalidParameterValueException in UserVmManagerImpl if userdata is not
base64 encoded.
> 
> 
> This addresses bug CS-14796.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManager.java 11d2c64 
>   server/src/com/cloud/vm/UserVmManagerImpl.java f441c72 
> 
> Diff: https://reviews.apache.org/r/6428/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message