incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranav Saxena" <pranav.sax...@citrix.com>
Subject Re: Review Request: CS-10219 Add option to set login attempts to portal.
Date Thu, 06 Sep 2012 19:36:32 GMT


> On Sept. 6, 2012, 7:04 p.m., Koushik Das wrote:
> > server/src/com/cloud/user/AccountManagerImpl.java, line 1879
> > <https://reviews.apache.org/r/6858/diff/5/?file=150231#file150231line1879>
> >
> >     Once the user account gets locked, what are the options to unlock. I don't see
any provision for that. So based on the current logic the user account becomes unusable. Should
that be the desired behavior

Root Admin has the rights to unlock the "locked account" of any user. The user can't unlock
his account on his own .So once his account his locked after n number of incorrect logins
, only the root admin can unlock his account Not very sure , but that is what I think is the
desired behaviour. 
 


- Pranav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6858/#review11119
-----------------------------------------------------------


On Sept. 6, 2012, 11:01 a.m., saksham srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6858/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2012, 11:01 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Alena Prokharchyk.
> 
> 
> Description
> -------
> 
> Added global setting login.attempts.allowed which defines the maximum incorrect password
attempts allowed.
> Also after the maximum attempts are reached the user account is disabled.
> 
> 
> This addresses bug CS-10219.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/user/UserAccountVO.java 5e7c018 
>   server/src/com/cloud/configuration/Config.java ebcd070 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java f9da08d 
>   server/src/com/cloud/user/AccountManagerImpl.java 38153f3 
>   setup/db/create-schema.sql fa933e3 
>   setup/db/db/schema-302to40.sql aaf23e6 
> 
> Diff: https://reviews.apache.org/r/6858/diff/
> 
> 
> Testing
> -------
> 
> Verified locally.
> 
> 
> Thanks,
> 
> saksham srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message