incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request: Fedora 17 openjdk 1.7 support
Date Thu, 06 Sep 2012 18:24:12 GMT


> On Sept. 6, 2012, 5:16 p.m., David Nalley wrote:
> > I don't see a problem with this specific change - the if statement is pretty limited
and leaves things alone for everything that isn't f17 or later. Hugo: Any objection if I commit
this? 
> > 
> >

The statement is ok, but Edison and myself are doing a lot of conflicting commits on cloud.spec
already. I'm afraid it gets lots if we are not carefull. By leaving this open using we have
solved the maven/ant thing we can be sure it gets in the build.

Or just commit it to both the maven-waf and master branch


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6941/#review11107
-----------------------------------------------------------


On Sept. 6, 2012, 7:17 a.m., Hiroaki Kawai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6941/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2012, 7:17 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> In fedora 17 package, openjdk 1.6 package was marked as deprecated, and only openjdk
1.7 is available for general.
> https://admin.fedoraproject.org/pkgdb/acls/name/java-1.6.0-openjdk
> 
> 
> Diffs
> -----
> 
>   cloud.spec b22bd8c 
> 
> Diff: https://reviews.apache.org/r/6941/diff/
> 
> 
> Testing
> -------
> 
> mvn && mvn test
> 
> 
> Thanks,
> 
> Hiroaki Kawai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message