incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "saksham srivastava" <saksham.srivast...@citrix.com>
Subject Re: Review Request: CS-10219 Add option to set login attempts to portal.
Date Wed, 05 Sep 2012 14:56:37 GMT


> On Sept. 4, 2012, 4:05 a.m., Vijay Venkatachalam wrote:
> > server/src/com/cloud/user/AccountManagerImpl.java, line 1869
> > <https://reviews.apache.org/r/6858/diff/3/?file=149072#file149072line1869>
> >
> >     Your intentions are good to give a custom log on the last erroneous login attempt.
But, the message says that you are disabling the account (it should be user), which is not
true. Also, you might want to throw an Exception with a message similar to the special log
message and not just log & return null. Returning null will give a generic message to
user - 'please provide valid credentials'.

Changed the log message. Using user instead of account.


- saksham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6858/#review11006
-----------------------------------------------------------


On Sept. 5, 2012, 2:56 p.m., saksham srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6858/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2012, 2:56 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Alena Prokharchyk.
> 
> 
> Description
> -------
> 
> Added global setting login.attempts.allowed which defines the maximum incorrect password
attempts allowed.
> Also after the maximum attempts are reached the user account is disabled.
> 
> 
> This addresses bug CS-10219.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/user/UserAccountVO.java 5e7c018 
>   server/src/com/cloud/configuration/Config.java ebcd070 
>   server/src/com/cloud/user/AccountManagerImpl.java 38153f3 
>   setup/db/create-schema.sql fa933e3 
>   setup/db/db/schema-302to40.sql aaf23e6 
> 
> Diff: https://reviews.apache.org/r/6858/diff/
> 
> 
> Testing
> -------
> 
> Verified locally.
> 
> 
> Thanks,
> 
> saksham srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message