incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay Venkatachalam" <vijay.venkatacha...@citrix.com>
Subject Review Request: CS-15783: Creating mapping between job ids and autoscale entity ids
Date Tue, 04 Sep 2012 12:24:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6899/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Deepak Garg.


Description
-------

1. After AutoScaleVmGroup creation, the asynchronous jobs cannot be listed momentarily.
   This happened because there was a mapping missing between the job
   instance id and autoscale vm group instance id.
   Fix: Introducing the mapping between job instance id and autoscale entity
   instance ids.
2. Updated JobInstance type in VmGroup commands.
3. Removing "action" as a mandatory parameter for listAutoScalePolicies command.


This addresses bug CS-15783.


Diffs
-----

  api/src/com/cloud/api/commands/DeleteAutoScaleVmGroupCmd.java b97d734 
  api/src/com/cloud/api/commands/DisableAutoScaleVmGroupCmd.java fa90fff 
  api/src/com/cloud/api/commands/EnableAutoScaleVmGroupCmd.java 4b4d1c3 
  api/src/com/cloud/api/commands/ListAutoScalePoliciesCmd.java 1d61641 
  api/src/com/cloud/api/response/AsyncJobResponse.java 3644595 

Diff: https://reviews.apache.org/r/6899/diff/


Testing
-------

1. Create AutoScalePolicyVmGroup through UI, the return values of query async job does not
return errors.
2. Fire api request command = listAutoScalePolicies with id alone. 


Thanks,

Vijay Venkatachalam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message