Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E947DDB5 for ; Wed, 29 Aug 2012 08:01:41 +0000 (UTC) Received: (qmail 44991 invoked by uid 500); 29 Aug 2012 08:01:41 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 44666 invoked by uid 500); 29 Aug 2012 08:01:38 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 44619 invoked by uid 99); 29 Aug 2012 08:01:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Aug 2012 08:01:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 694091C0CF1; Wed, 29 Aug 2012 08:01:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4161891494206797529==" MIME-Version: 1.0 Subject: Review Request: CS-16168 [AutoScale] : Deletion of Account doesn't delete the AutoScale LB rule From: "Deepak Garg" To: "Vijay Venkatachalam" , "Pranav Saxena" Cc: "cloudstack" , "Deepak Garg" Date: Wed, 29 Aug 2012 08:01:36 -0000 Message-ID: <20120829080136.27228.66499@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Deepak Garg" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/6825/ X-Sender: "Deepak Garg" Reply-To: "Deepak Garg" --===============4161891494206797529== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6825/ ----------------------------------------------------------- Review request for cloudstack, Pranav Saxena and Vijay Venkatachalam. Description ------- CS-16168 [AutoScale] : Deletion of Account doesn't delete the AutoScale LB rule Steps = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D = 1. Create a Domain inside the ROOT domain, and then create a user for that = domain. = 2. Login to CS as that user and create an Autoscale LB rule. = 3. Let the LB rule get created and the minimum number of VM deployed. Now D= elete the Account. = Observation = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D = 1. The LB rule Doesn't get deleted (The attached VM gets deleted but the Au= toScale LB rule stays) = This addresses bug CS-16168. Diffs ----- server/src/com/cloud/network/as/AutoScaleManager.java 7ea7807 = server/src/com/cloud/network/as/AutoScaleManagerImpl.java 8c39097 = server/src/com/cloud/network/as/dao/AutoScalePolicyDao.java 8edfa94 = server/src/com/cloud/network/as/dao/AutoScalePolicyDaoImpl.java 5dfe080 = server/src/com/cloud/network/as/dao/AutoScaleVmProfileDao.java 0803571 = server/src/com/cloud/network/as/dao/AutoScaleVmProfileDaoImpl.java 12392c= 3 = server/src/com/cloud/network/as/dao/ConditionDao.java bb0f77f = server/src/com/cloud/network/as/dao/ConditionDaoImpl.java 338fe19 = server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 867115= 1 = server/src/com/cloud/user/AccountManagerImpl.java 0a11dc4 = Diff: https://reviews.apache.org/r/6825/diff/ Testing ------- Manually tested on my setup. Thanks, Deepak Garg --===============4161891494206797529==--