Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37D55D891 for ; Fri, 17 Aug 2012 23:08:33 +0000 (UTC) Received: (qmail 62012 invoked by uid 500); 17 Aug 2012 23:08:33 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 61984 invoked by uid 500); 17 Aug 2012 23:08:32 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 61965 invoked by uid 99); 17 Aug 2012 23:08:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Aug 2012 23:08:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4093B1C1BA8; Fri, 17 Aug 2012 23:08:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6748434639081292120==" MIME-Version: 1.0 Subject: Re: Review Request: CS-15778:-Fetching-thumbnail From: "Kelven Yang" To: "Kelven Yang" Cc: "Rajesh Battala" , "cloudstack" Date: Fri, 17 Aug 2012 23:08:31 -0000 Message-ID: <20120817230831.23839.31999@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kelven Yang" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/6608/ X-Sender: "Kelven Yang" References: <20120817135256.23841.29113@reviews.apache.org> In-Reply-To: <20120817135256.23841.29113@reviews.apache.org> Reply-To: "Kelven Yang" --===============6748434639081292120== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6608/#review10486 ----------------------------------------------------------- I can't apply the patch as git throws errors, could you double check if you= r patch is properly generated (for example, no unresolved conflicts, use sp= ace in place of tabs and don't mix space and tabs) - Kelven Yang On Aug. 17, 2012, 1:52 p.m., Rajesh Battala wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6608/ > ----------------------------------------------------------- > = > (Updated Aug. 17, 2012, 1:52 p.m.) > = > = > Review request for cloudstack and Kelven Yang. > = > = > Description > ------- > = > When a viewer is launched, the images are getting stored in AjaxImageFifo= Cache class. > When request for thumbnail, we need to pass "key" param to retreive the i= mage and its not getting passed so thumbnail is requested its failing with = NPE. = > Issue is fixed by passing key param with default value 0 and Image is ret= rieved with the current key value. > = > = > This addresses bug CS-15778. > = > = > Diffs > ----- > = > console-proxy/src/com/cloud/consoleproxy/ConsoleProxyAjaxImageHandler.j= ava 1fdda2e = > = > Diff: https://reviews.apache.org/r/6608/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Rajesh Battala > = > --===============6748434639081292120==--