Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 02D79D8A5 for ; Thu, 16 Aug 2012 20:27:48 +0000 (UTC) Received: (qmail 46248 invoked by uid 500); 16 Aug 2012 20:27:47 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 46216 invoked by uid 500); 16 Aug 2012 20:27:47 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 46206 invoked by uid 99); 16 Aug 2012 20:27:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Aug 2012 20:27:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 38CA51C1A59; Thu, 16 Aug 2012 20:27:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1906660129327647203==" MIME-Version: 1.0 Subject: Re: Review Request: Update RPM build for 4.0 From: "Marcus Sorensen" To: "Marcus Sorensen" , "cloudstack" , "edison su" Date: Thu, 16 Aug 2012 20:27:46 -0000 Message-ID: <20120816202746.23841.89934@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Marcus Sorensen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/6658/ X-Sender: "Marcus Sorensen" References: <20120816201438.23841.73727@reviews.apache.org> In-Reply-To: <20120816201438.23841.73727@reviews.apache.org> Reply-To: "Marcus Sorensen" --===============1906660129327647203== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 16, 2012, 8:14 p.m., edison su wrote: > > cloud.spec, line 535 > > > > > > I think we need config(noreplace) for this configuration files: db.= properties/log4j-cloud.xml/tomcat6.conf. Admin usually will change these co= nfiguration files to suite their needs, without noreplace, these files will= be replaced with a new cloudstack RPM upgrade. The reason that was pulled is because line 531 includes db.properties, and = so we get an RPM build error stating that the file was asked for twice. Li= ke 531 is already (noreplace) - Marcus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6658/#review10428 ----------------------------------------------------------- On Aug. 16, 2012, 7:26 p.m., Marcus Sorensen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6658/ > ----------------------------------------------------------- > = > (Updated Aug. 16, 2012, 7:26 p.m.) > = > = > Review request for cloudstack. > = > = > Description > ------- > = > Update cloud.spec for current state of 4.0, minor waf and init script fix= es for RHEL/CENTOS/Fedora > = > = > Diffs > ----- > = > agent/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-agent.in 488ced2 = > agent/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-agent.in 488ced2 = > agent/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-agent.in 488ced2 = > cloud.spec 47a457a = > wscript 9e9acbd = > = > Diff: https://reviews.apache.org/r/6658/diff/ > = > = > Testing > ------- > = > Tested on Centos 6.2 x64 > Build RPMS via './waf rpm' : passed > Installed RPMS to management server : passed > Installed RPMs to hypervisor host : passed > Started/stopped via init scripts : passed > Create zone, deploy instance : passed > = > = > Thanks, > = > Marcus Sorensen > = > --===============1906660129327647203==--