Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5D9B29F73 for ; Thu, 16 Aug 2012 09:09:04 +0000 (UTC) Received: (qmail 80492 invoked by uid 500); 16 Aug 2012 09:09:04 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 80331 invoked by uid 500); 16 Aug 2012 09:09:04 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 80298 invoked by uid 99); 16 Aug 2012 09:09:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Aug 2012 09:09:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CB54F1C0C42; Thu, 16 Aug 2012 09:09:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1841216375230214625==" MIME-Version: 1.0 Subject: Re: Review Request: CS-15823 Failed snapshot should be marked as Error and cleanup asynchronously From: "mice xia" To: "edison su" , "Nitin Mehta" Cc: "cloudstack" , "mice xia" Date: Thu, 16 Aug 2012 09:09:01 -0000 Message-ID: <20120816090901.23840.30072@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "mice xia" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/6325/ X-Sender: "mice xia" References: <20120816063452.23841.82806@reviews.apache.org> In-Reply-To: <20120816063452.23841.82806@reviews.apache.org> Reply-To: "mice xia" --===============1841216375230214625== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 16, 2012, 6:34 a.m., Nitin Mehta wrote: > > Do we delete DB rows for error conditions for any other resources in CS= as well or do we want to give snapshots a different treatment here ? I am = somehow not very comfortable doing hard delete here. by performing a global search with key word 'Dao.expunge(', similar hard de= letes are found in storage package, like volumes/storagePool that failed to= create get expunged, and considering codes before applying this patch are = also using expunge, is it the author's original idea to make a distinction?= Resources that ever exist get 'Removed', and Resources that never really e= xist get 'Expunged'. - mice ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6325/#review10394 ----------------------------------------------------------- On Aug. 11, 2012, 1:13 a.m., mice xia wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6325/ > ----------------------------------------------------------- > = > (Updated Aug. 11, 2012, 1:13 a.m.) > = > = > Review request for cloudstack, Nitin Mehta and edison su. > = > = > Description > ------- > = > changes: > marked failed snapshots as Error and expunge them in a background thread,= the cleanup interval is storage.cleanup.interval > = > = > This addresses bug CS-15823. > = > = > Diffs > ----- > = > server/src/com/cloud/storage/StorageManagerImpl.java c17379f = > server/src/com/cloud/storage/dao/SnapshotDao.java 4bf54de = > server/src/com/cloud/storage/dao/SnapshotDaoImpl.java ac4bb6f = > server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 6e3f9c1 = > = > Diff: https://reviews.apache.org/r/6325/diff/ > = > = > Testing > ------- > = > verified > = > = > Thanks, > = > mice xia > = > --===============1841216375230214625==--