Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============0796770193999745383=="
MIME-Version: 1.0
Subject: Review Request: POC VIF plugin implementation
From: "Tomoe Sugihara" <tomoe@midokura.com>
To: "Chiradeep Vittal" <chiradeepv@gmail.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Tomoe Sugihara" <tomoe@midokura.com>
Date: Wed, 01 Aug 2012 16:42:40 -0000
Message-ID: <20120801164240.22302.33971@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Tomoe Sugihara" <noreply@reviews.apache.org>
Reply-To: "Tomoe Sugihara" <tomoe@midokura.com>

--===============0796770193999745383==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6285/
-----------------------------------------------------------

Review request for cloudstack and Chiradeep Vittal.


Description
-------

POC VIF plugin implementation
-----------------------------

- This allows vendors to implement their of plug/unplug logic, and users ca=
n choose one by specifying "libvirt.vif.driver" parameter in agent.properti=
es file.
  - if it is not specified, it defaults to the current implementation with =
Linux bridge.
- This work is still half way in that:
  - unplug hasn't been implemented
  - I was going to factor out the existing default implementation with Linu=
x bridge to something like LibvirtBridgeVifDriver, but there's a bunch of d=
ependencies (on methods and fields in LibvirtComputingResource and VirtualR=
outingResource) and I couldn't finish it. Ultimately, all the networking sp=
ecific logic should be separated from LibvirtComputingResource to vif drive=
r.
 =


Diffs
-----

  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComp=
utingResource.java ea12b986b0a771c028354637a657b100fc3cfa27 =


Diff: https://reviews.apache.org/r/6285/diff/


Testing
-------


Thanks,

Tomoe Sugihara


--===============0796770193999745383==--