Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F333FD4F0 for ; Wed, 1 Aug 2012 06:22:07 +0000 (UTC) Received: (qmail 32924 invoked by uid 500); 1 Aug 2012 06:22:06 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 32584 invoked by uid 500); 1 Aug 2012 06:22:04 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 32521 invoked by uid 99); 1 Aug 2012 06:22:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2012 06:22:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6CC591C0378; Wed, 1 Aug 2012 06:22:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2684330628276426955==" MIME-Version: 1.0 Subject: Re: Review Request: CS-15775: Creation of Auto scale configuration through UI fails while creating autoscale profile due to args.context.ipAddresses is undefined From: "Pranav Saxena" To: "Jessica Wang" , "Brian Federle" , "Pranav Saxena" Cc: "cloudstack" , "Sanjay Tripathi" Date: Wed, 01 Aug 2012 06:22:01 -0000 Message-ID: <20120801062201.22301.3036@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Pranav Saxena" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/6245/ X-Sender: "Pranav Saxena" References: <20120801042152.22302.79520@reviews.apache.org> In-Reply-To: <20120801042152.22302.79520@reviews.apache.org> Reply-To: "Pranav Saxena" --===============2684330628276426955== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6245/#review9676 ----------------------------------------------------------- Ship it! Verified the changes on my set up. Looks good ! Thanks for the patch . - Pranav Saxena On Aug. 1, 2012, 4:21 a.m., Sanjay Tripathi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6245/ > ----------------------------------------------------------- > = > (Updated Aug. 1, 2012, 4:21 a.m.) > = > = > Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica = Wang. > = > = > Description > ------- > = > Basic zone, EIP ELB N/w Offering. = > Unable to create Autoscale policy from UI = > Steps = > =3D=3D=3D=3D=3D = > = > Network -> GuestNetwork -> AddLoadBalancer -> provide name/port -> Autosc= ale - Configure -> Provide all autoscale configs = > = > autoscale conditions are created. But at queryAsyncJob of createAutoScale= VmProfile, it stops responding. Conditions and profile gets created in the = DB: = > = > 10 | 192dbc28-b6e3-4df0-ab73-c4e7c359adfc | 1 | 70 | GT | 1 | 2 | NULL |= 2012-07-31 07:13:25 | = > | 11 | 48f10dc4-0f4b-459b-91a7-2feb2109c322 | 1 | 30 | GT | 1 | 2 | NULL = | 2012-07-31 07:13:32 | = > = > = > | 5 | c03f373c-1f7c-421a-8377-4c373a57cf71 | 1 | 1 | 2 | 2 | 1 | 5 | NULL= | 30 | public | 161 | 2012-07-31 07:13:38 | NULL | = > = > = > This addresses bug CS-15775. > = > = > Diffs > ----- > = > ui/scripts/autoscaler.js ff5c542 = > = > Diff: https://reviews.apache.org/r/6245/diff/ > = > = > Testing > ------- > = > Verified on my local Cloudstack setup. > = > = > Thanks, > = > Sanjay Tripathi > = > --===============2684330628276426955==--