incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject Re: Review Request: Improve portability of the build-apidoc.sh script by replacing readlink
Date Wed, 22 Aug 2012 19:47:30 GMT
Greg,

This was applied to master.

I can't get to the reviews.a.o site yet (apparently due to a power outage
at one of the ASF infra colo providers to update the review), but thank you
for the patch!

-chip

On Wed, Aug 22, 2012 at 2:55 PM, Chip Childers <chip.childers@sungard.com>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6733/
>
> Tested locally on OSX as well.  Looks like it fixes the issue.
>
> I'm testing on Ubuntu 12 now.  I'll commit this if it works correctly there.
>
>
> - Chip
>
> On August 22nd, 2012, 4:57 p.m., Greg Burd wrote:
>   Review request for cloudstack.
> By Greg Burd.
>
> *Updated Aug. 22, 2012, 4:57 p.m.*
> Description
>
> `readlink -f` is not supported on OSX.  I've replaced it with a bash function which should
be portable and accomplish the same result.
>
>   Testing
>
> I've tested this on my OSX 10.8 system with the latest Xcode 4.4.1 but not any other
systems.
>
>   Diffs
>
>    - setup/apidoc/build-apidoc.sh (618273f)
>
> View Diff <https://reviews.apache.org/r/6733/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message