incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Will Chan <will.c...@citrix.com>
Subject RE: Review Request: Replace db-id by UUID for user VM's vm-id.
Date Wed, 29 Aug 2012 05:05:03 GMT
I guess the instance-id is synonymous with vm-id.  

________________________________________
From: Vijayendra Bhamidipati [vijayendra.bhamidipati@citrix.com]
Sent: Tuesday, August 28, 2012 8:01 PM
To: cloudstack-dev@incubator.apache.org; Fang Wang
Subject: RE: Review Request: Replace db-id by UUID for user VM's vm-id.

Hi Will!

Chiradeep pointed out in his comments in the bug that the instance-id should be supported:

Chiradeep Vittal added a comment - 20/Jul/12 5:28 PM
The ones that CAN be supported are here:
http://docs.amazonwebservices.com/AWSEC2/latest/UserGuide/AESDG-chapter-instancedata.html#instancedata-data-categories
Of these, these SHOULD be supported:
ami-id (template id)
instance-id
<snip>

I'm guessing we will need it to ensure that we support the EC2 VM metadata specs? Will there
be any -ve impact upon not exposing instance-id?

Regards,
Vijay


-----Original Message-----
From: Will Chan [mailto:will.chan@citrix.com]
Sent: Tuesday, August 28, 2012 7:31 PM
To: cloudstack-dev@incubator.apache.org; Fang Wang
Subject: RE: Review Request: Replace db-id by UUID for user VM's vm-id.

Fang,

We should remove instance-id as well because no user should have access to the CS generated
name.

Will

________________________________________
From: Fang Wang [noreply@reviews.apache.org] On Behalf Of Fang Wang [fang.wang@citrix.com]
Sent: Tuesday, August 28, 2012 3:49 PM
To: Kelven Yang
Cc: cloudstack; Fang Wang
Subject: Review Request: Replace db-id by UUID for user VM's vm-id.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6814/
-----------------------------------------------------------

Review request for cloudstack and Kelven Yang.


Description
-------

Output uuid instead of db_id for vm_id.


This addresses bug cs-15627.


Diffs
-----

  api/src/com/cloud/vm/VirtualMachineProfile.java 30aed4e
  server/src/com/cloud/network/element/CloudZonesNetworkElement.java 5f93cac
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 0aaad10
  server/src/com/cloud/vm/VirtualMachineProfileImpl.java 6028c95

Diff: https://reviews.apache.org/r/6814/diff/


Testing
-------

Verified on user VM.


Thanks,

Fang Wang
Mime
View raw message