incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Krishna Sadasivam <ksada...@Brocade.com>
Subject RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack
Date Thu, 09 Aug 2012 17:47:19 GMT
Thanks for your feedback.

Here are list of capabilities in the current patch:
* There is no virtual appliance for ADX as of now. The Virtual ADX itself is in development.
So CloudStack support for software LB is not available in this patch.
* Brocade ADX will be LB provider in advanced zone only. I am still looking at what is required
to make it work in basic zone.
* Static Nat commands are implemented. However EIP support is not intended. 
* We are add a pool of ADX devices to a physical network. Both dedicated and shared mode are
supported. 

Thanks,
Krishna  

-----Original Message-----
From: Murali Reddy [mailto:Murali.Reddy@citrix.com] 
Sent: Thursday, August 09, 2012 2:08 AM
To: cloudstack-dev@incubator.apache.org; Krishna Sadasivam
Subject: Re: Review Request: Plugin for enabling Brocade as external load balancing service
provider in CloudStack


Thanks for submitting patch. I took a quick look at the patch in general things look good.
It would be better if you can give quick context on the ADX capabilities for better deatiled
review. Some question I had was does ADX has a virtual appliance? NAT capabilities? Also where
do you want to position Brocade ADX as LB provider in advanced zone only or both advanced
and basic zones? I see that you implemented static NAT commands also, do you intend that with
this patch Brocade SDX can be EIP provider in basic zone? I think currently EIP is hard coded
to be provided by NetScaler devices, so you might want to relax that restriction for ADX to
be EIP provider.

You may be aware, but just wanted to let you know. CloudStack has support for notion of pool
of load balancer that can cloud-operator provision into a zone, so there could more than one
ADX device in a physical network with the ability to offer a dedicated/shared load balancers
based on the network offering. So please call out what patch is supporting. Let me know if
you need any further details.


On 09/08/12 5:01 AM, "Krishna Sadasivam" <ksadasiv@brocade.com> wrote:

>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/6492/
>-----------------------------------------------------------
>
>Review request for cloudstack.
>
>
>Description
>-------
>
>This is the patch for adding Brocade plugin to enable Brocade LBs in 
>CloudStack. The plugin can support Lb service in advanced zone networking.
>Lb services: 
>*Protocols: TCP/UDP
>*Lb algorithms: roundrobin, leastconn, weighted, weightedroundrobin, 
>weighted round robin static, enhanced weighted, responsetime *Sticky 
>Session persistence using sticky port
>
>
>Diffs
>-----
>
>  build/build-cloud-plugins.xml a7a1f39
>  build/build-cloud.xml b4d120f
>  build/developer.xml d52b682
>  client/tomcatconf/brocadeloadbalancer_commands.properties.in
>PRE-CREATION
>  client/tomcatconf/components.xml.in da7617d
>  deps/.classpath 1376b4f
>  deps/cloud-BrocadeService.jar PRE-CREATION
>  plugins/network-elements/brocade/.classpath PRE-CREATION
>  plugins/network-elements/brocade/.project PRE-CREATION
>  plugins/network-elements/brocade/build.xml PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/AddBrocadeL
>oad
>BalancerCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/ConfigureBr
>oca
>deLoadBalancerCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/DeleteBroca
>deL
>oadBalancerCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocade
>Loa
>dBalancerNetworksCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/ListBrocade
>Loa
>dBalancersCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeight
>Com
>mand.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/commands/SetVmWeight
>For
>LbPredictorCmd.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/api/response/BrocadeLoad
>Bal
>ancerResponse.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeE
>lem
>ent.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/network/element/BrocadeL
>oad BalancerElementService.java PRE-CREATION
>  
>plugins/network-elements/brocade/src/com/cloud/network/resource/Brocade
>ADX
>Resource.java PRE-CREATION
>  
>plugins/network-elements/brocade/test/com/cloud/network/element/Base64.
>jav
>a PRE-CREATION
>  
>plugins/network-elements/brocade/test/com/cloud/network/element/Brocade
>Plu
>ginTest.java PRE-CREATION
>
>Diff: https://reviews.apache.org/r/6492/diff/
>
>
>Testing
>-------
>
>Unit tests, Rest API calls from Rest client code
>
>
>Thanks,
>
>Krishna Sadasivam
>
>



Mime
View raw message