incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Huang" <alex.hu...@citrix.com>
Subject Re: Review Request: CS-15694:Remove MYSQL connector. Added the explicit class path for mysql connector which will call the jar from the desired location
Date Fri, 31 Aug 2012 15:06:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6752/#review10942
-----------------------------------------------------------


- For build-cloud.properties, that line should be optional.  This means add a '#' in front
of it and others an make it required when copying it into override.
- The change for developer.xml to read in the build-cloud.xml should be done as a precondition
to all build targets.
- The change does not take into account that the file may be on the class path and so the
property value should only be optional.  Here it made it explicit.
- 

- Alex Huang


On Aug. 24, 2012, 10:19 a.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6752/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2012, 10:19 a.m.)
> 
> 
> Review request for cloudstack, David Nalley and Alex Huang.
> 
> 
> Description
> -------
> 
> CS-15694:Remove MYSQL connector. Added the explicit class path for mysql connector which
will call the jar from the desired location
> 
> 
> Diffs
> -----
> 
>   build/build-cloud.properties 552de7f74db7b715da70cc48ff4dc8945fa066f8 
>   build/developer.xml f2e5aa6463ec849a3e97343e82423ff0ac622222 
>   setup/db/deploy-db-dev.sh f149e9efd029bd311b1d247e21764b9103fd01d9 
> 
> Diff: https://reviews.apache.org/r/6752/diff/
> 
> 
> Testing
> -------
> 
> Executed: "ant build-all deploy-server deploydb" successfully.
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message