incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers" <chip.child...@sungard.com>
Subject Re: Review Request: Change license to ASL2.0 in server and tools
Date Thu, 30 Aug 2012 13:12:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6854/#review10886
-----------------------------------------------------------


Gavin,

Thanks a ton for these header changes.  One request:  For the .sql files, can you use the
"--" comment approach?  That seems to work the best with the Apache RAT auditing tool.

If you can make that change, and resubmit the patch, I'll apply to master.

- Chip Childers


On Aug. 30, 2012, 12:50 p.m., Gavin Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6854/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2012, 12:50 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Chip Childers.
> 
> 
> Description
> -------
> 
> Correct license header to ASL2.0 in server,tools,test and script folder
> 
> 
> Diffs
> -----
> 
>   scripts/network/domr/s2s_vpn.sh 0bdccc4 
>   server/src/com/cloud/upgrade/dao/Upgrade30xBase.java 63047a2 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 8841483 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java 579e92c 
>   server/test/com/cloud/vpc/MockResourceLimitManagerImpl.java 0a199f5 
>   server/test/com/cloud/vpc/MockSite2SiteVpnManagerImpl.java cb200f4 
>   server/test/com/cloud/vpc/MockVpcManagerImpl.java 4b0aa33 
>   server/test/com/cloud/vpc/VpcApiUnitTest.java efeee5e 
>   server/test/com/cloud/vpc/dao/MockConfigurationDaoImpl.java 0cac4b9 
>   server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java 970a5d9 
>   server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java dfeadf6 
>   server/test/com/cloud/vpc/dao/MockNetworkOfferingServiceMapDaoImpl.java 2e388c2 
>   server/test/com/cloud/vpc/dao/MockNetworkServiceMapDaoImpl.java e66aa5b 
>   server/test/com/cloud/vpc/dao/MockVpcDaoImpl.java f59277b 
>   server/test/com/cloud/vpc/dao/MockVpcOfferingDaoImpl.java 2a808ef 
>   server/test/com/cloud/vpc/dao/MockVpcOfferingServiceMapDaoImpl.java 6ac4234 
>   server/test/com/cloud/vpc/dao/MockVpcVirtualRouterElement.java 91cfb99 
>   server/test/resources/cleanup.sql ac083d7 
>   server/test/resources/fake.sql 37f96ce 
>   setup/db/create-schema.sql fa933e3 
>   test/conf/templates.sql 1b31764 
>   tools/ant/apache-ant-1.7.1/bin/runant.py ef70325 
>   tools/build/addcopyright.py 719ec1b 
>   tools/migration/XenAPI.py a432400 
>   tools/migration/share_all_lus.sh e5641e2 
>   tools/migration/upgrade.py 2680518 
>   tools/waf/javadir.py 6f9c905 
>   tools/waf/mkisofs.py 62f4dc8 
>   tools/waf/tar.py 30ca191 
>   tools/waf/tomcat.py ff8a0d0 
>   tools/waf/usermgmt.py 04234b4 
> 
> Diff: https://reviews.apache.org/r/6854/diff/
> 
> 
> Testing
> -------
> 
> Passed build-all, deploy-server,deploydb and basic function testing
> 
> 
> Thanks,
> 
> Gavin Lee
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message