incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Re: Review Request: permissions fix for agent creating /root/.ssh
Date Mon, 27 Aug 2012 22:54:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6793/
-----------------------------------------------------------

(Updated Aug. 27, 2012, 10:54 p.m.)


Review request for cloudstack.


Changes
-------

needed to change the comment as well to show 700 instead of 600


Description
-------

/root/.ssh is created with perms '600' if it doesn't already exist. This causes a problem
in that it can't write out id_rsa.cloud:

2012-08-27 16:35:40,227 DEBUG [cloud.agent.Agent] (agentRequest-Handler-4:null) Processing
command: com.cloud.agent.api.ModifySshKeysCommand
2012-08-27 16:35:40,228 DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-4:null)
Failed to create file: java.io.IOException: Permission denied

Doing 'chmod u+x /root/.ssh' fixed the above, so it seems that even though the agent is running
as root it cares about being able to chdir into /root.ssh


Diffs (updated)
-----

  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
5623260 

Diff: https://reviews.apache.org/r/6793/diff/


Testing
-------

removed /root/.ssh, restarted cloud-agent, and saw that the id_rsa.cloud gets populated now.


Thanks,

Marcus Sorensen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message