incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajesh Battala" <rajesh.batt...@citrix.com>
Subject Re: Review Request: CS-15778:-Fetching-thumbnail
Date Mon, 27 Aug 2012 11:54:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6608/
-----------------------------------------------------------

(Updated Aug. 27, 2012, 11:54 a.m.)


Review request for cloudstack and Kelven Yang.


Changes
-------

Attached Screenshot


Description
-------

When a viewer is launched, the images are getting stored in AjaxImageFifoCache class.
When request for thumbnail, we need to pass "key" param to retreive the image and its not
getting passed so thumbnail is requested its failing with NPE. 
Issue is fixed by passing key param with default value 0 and Image is retrieved with the current
key value.


This addresses bug CS-15778.


Diffs
-----

  console-proxy/src/com/cloud/consoleproxy/AjaxFIFOImageCache.java c9b5b60 
  console-proxy/src/com/cloud/consoleproxy/ConsoleProxyAjaxImageHandler.java 1fdda2e 
  server/src/com/cloud/servlet/ConsoleProxyServlet.java a8519fe 

Diff: https://reviews.apache.org/r/6608/diff/


Testing
-------


Thanks,

Rajesh Battala


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message