incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Darren Shepherd" <dar...@godaddy.com>
Subject RE: maven: why move tabs -> ws?
Date Mon, 27 Aug 2012 17:06:40 GMT
Alex,

The actual Java coding standard from Sun (now Oracle) doesn't really
specify if tabs or spaces should be used.  Its section 4 at
http://www.oracle.com/technetwork/java/codeconventions-150003.pdf  I'd
never seen the one from geosoft.no that the wiki refers to.

Regardless, I really don't care.  I'll make sure my stuff has spaces in
it.

Darren




> -------- Original Message --------
> Subject: RE: maven: why move tabs -> ws?
> From: Alex Huang <Alex.Huang@citrix.com>
> Date: Mon, August 27, 2012 9:51 am
> To: "cloudstack-dev@incubator.apache.org"
> <cloudstack-dev@incubator.apache.org>
> 
> 
> We do have a coding convention document here but it's for Java.  The standard for Java
is to use four spaces to indent.  No tabs allowed.  The reason is practical.  It reads much
better on a web browser when browsing around in git.
> 
> 
> 
> http://docs.cloudstack.org/CloudStack_Documentation/Design_Documents/Coding_Conventions
> 
> 
> 
> --Alex
> 
> 
> 
> > -----Original Message-----
> 
> > From: Darren Shepherd [mailto:darren@godaddy.com]
> 
> > Sent: Monday, August 27, 2012 9:44 AM
> 
> > To: cloudstack-dev@incubator.apache.org
> 
> > Subject: RE: maven: why move tabs -> ws?
> 
> > 
> 
> > Looks like the decision has already been made.  2 spaces it is.  No problem.
> 
> > 
> 
> > Darren
> 
> > 
> 
> > 
> 
> > 
> 
> > 
> 
> > > -------- Original Message --------
> 
> > > Subject: Re: maven: why move tabs -> ws?
> 
> > > From: Olivier Lamy <olamy@apache.org>
> 
> > > Date: Mon, August 27, 2012 8:34 am
> 
> > > To: cloudstack-dev@incubator.apache.org
> 
> > >
> 
> > >
> 
> > > Hi,
> 
> > > Yup a vote seems reasonable on this sensible holy war question :-) I
> 
> > > will do that.
> 
> > >
> 
> > > 2012/8/27 Darren Shepherd <darren@godaddy.com>:
> 
> > > > Yes there are style files for Eclipse.  But I'm pretty opposed to
> 
> > > > changing the default style of Eclipse.  The default style of Eclipse
> 
> > > > is pretty darn close to the Sun java coding standard put out in 99
> 
> > > > that most java projects seems to follow.  Maybe Apache has their own
> 
> > > > subculture, but in general I've seen most java projects follow that
> 
> > > > standard in some loose fashion.  Requiring people to change the
> 
> > > > default style just seems to end up with having to police the code style
> 
> > more.
> 
> > > > And unless you start a project from fresh with a tool like
> 
> > > > checkstyle, it doesn't help.
> 
> > > >
> 
> > > > Is it possible to move back to tabs?  Can we have a vote or something?
> 
> > > > My immediate problem is that all of the my patches I have in my
> 
> > > > queue to submit just got invalidated because they just all look like
> 
> > > > conflicts now.
> 
> > > >
> 
> > > > Darren
> 
> > > >
> 
> > > >
> 
> > > >
> 
> > > >
> 
> > > >> -------- Original Message --------
> 
> > > >> Subject: Re: maven: why move tabs -> ws?
> 
> > > >> From: Olivier Lamy <olamy@apache.org>
> 
> > > >> Date: Sun, August 26, 2012 11:59 pm
> 
> > > >> To: cloudstack-dev@incubator.apache.org
> 
> > > >>
> 
> > > >>
> 
> > > >> 2012/8/27 Darren Shepherd <darren@godaddy.com>:
> 
> > > >> > Olivier,
> 
> > > >> >
> 
> > > >> > Why is there a strong preference of white space over tabs for
the
> 
> > > >> > pom.xml's?  I noticed you changed all of them.  The thing is,
> 
> > > >> > when I created all the pom files I actually created them with
2
> 
> > > >> > spaces instead of tabs (that's my vim settings).  When I start
> 
> > > >> > using the pom's in Eclipse it donned on me that the Eclipse
> 
> > > >> > default is to use tabs over spaces and thus when you go to edit
> 
> > > >> > the pom's in Eclipse you end up with poorly formatted garbage.
> 
> > > >> > So I actually went through and reformatted everything with tabs.
> 
> > > >> >
> 
> > > >> > Is there a strong standard to use spaces instead of tabs?  I
> 
> > > >> > kinda thought the java world (and xml world) seemed to prefer
tabs in
> 
> > general.
> 
> > > >> Perso all opensource projects I'm involved @apache and others use
> 
> > *only* spaces.
> 
> > > >> So maybe I'm maniac :-)
> 
> > > >>
> 
> > > >> A more general question I have: is there any style files for ide ?
> 
> > > >> (at least eclipse and idea).
> 
> > > >>
> 
> > > >> >
> 
> > > >> > Darren
> 
> > > >> >
> 
> > > >> >
> 
> > > >> >
> 
> > > >> >
> 
> > > >>
> 
> > > >>
> 
> > > >>
> 
> > > >> --
> 
> > > >> Olivier Lamy
> 
> > > >> Talend: http://coders.talend.com
> 
> > > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> 
> > >
> 
> > >
> 
> > >
> 
> > > --
> 
> > > Olivier Lamy
> 
> > > Talend: http://coders.talend.com
> 
> > > http://twitter.com/olamy | http://linkedin.com/in/olamy

Mime
View raw message