incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers" <chip.child...@sungard.com>
Subject Re: Review Request: Improve portability of the build-apidoc.sh script by replacing readlink
Date Wed, 22 Aug 2012 18:55:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6733/#review10632
-----------------------------------------------------------


Tested locally on OSX as well.  Looks like it fixes the issue.

I'm testing on Ubuntu 12 now.  I'll commit this if it works correctly there.

- Chip Childers


On Aug. 22, 2012, 4:57 p.m., Greg Burd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6733/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2012, 4:57 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> `readlink -f` is not supported on OSX.  I've replaced it with a bash function which should
be portable and accomplish the same result.
> 
> 
> Diffs
> -----
> 
>   setup/apidoc/build-apidoc.sh 618273f 
> 
> Diff: https://reviews.apache.org/r/6733/diff/
> 
> 
> Testing
> -------
> 
> I've tested this on my OSX 10.8 system with the latest Xcode 4.4.1 but not any other
systems.
> 
> 
> Thanks,
> 
> Greg Burd
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message