incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kelven Yang" <kelven.y...@citrix.com>
Subject Re: Review Request: CS-15778:-Fetching-thumbnail
Date Fri, 17 Aug 2012 23:08:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6608/#review10486
-----------------------------------------------------------


I can't apply the patch as git throws errors, could you double check if your patch is properly
generated (for example, no unresolved conflicts, use space in place of tabs and don't mix
space and tabs)

- Kelven Yang


On Aug. 17, 2012, 1:52 p.m., Rajesh Battala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6608/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2012, 1:52 p.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> When a viewer is launched, the images are getting stored in AjaxImageFifoCache class.
> When request for thumbnail, we need to pass "key" param to retreive the image and its
not getting passed so thumbnail is requested its failing with NPE. 
> Issue is fixed by passing key param with default value 0 and Image is retrieved with
the current key value.
> 
> 
> This addresses bug CS-15778.
> 
> 
> Diffs
> -----
> 
>   console-proxy/src/com/cloud/consoleproxy/ConsoleProxyAjaxImageHandler.java 1fdda2e

> 
> Diff: https://reviews.apache.org/r/6608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message