incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "edison su" <edison...@citrix.com>
Subject Re: Review Request: Update RPM build for 4.0
Date Thu, 16 Aug 2012 22:52:50 GMT


> On Aug. 16, 2012, 8:14 p.m., edison su wrote:
> > cloud.spec, line 535
> > <https://reviews.apache.org/r/6658/diff/1/?file=141513#file141513line535>
> >
> >     I think we need config(noreplace) for this configuration files: db.properties/log4j-cloud.xml/tomcat6.conf.
Admin usually will change these configuration files to suite their needs, without noreplace,
these files will be replaced with a new cloudstack RPM upgrade.
> 
> Marcus Sorensen wrote:
>     The reason that was pulled is because line 531 includes db.properties, and so we
get an RPM build error stating that the file was asked for twice.  Like 531 is already (noreplace)
> 
> Marcus Sorensen wrote:
>     I updated the diff, the previous iteration works, but it was neglecting the permissions
on the Catalina directory (which is empty on my system so perhaps it doesn't matter), the
db.properties gets the correct permissions via initial install per cloud-setup-databases,
but might as well change as little as possible.

Could you send a new patch based the latest code?


- edison


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6658/#review10428
-----------------------------------------------------------


On Aug. 16, 2012, 10:04 p.m., Marcus Sorensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6658/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2012, 10:04 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Update cloud.spec for current state of 4.0, minor waf and init script fixes for RHEL/CENTOS/Fedora
> 
> 
> Diffs
> -----
> 
>   agent/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-agent.in 488ced2 
>   agent/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-agent.in 488ced2 
>   agent/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-agent.in 488ced2 
>   cloud.spec 47a457a 
>   wscript 9e9acbd 
> 
> Diff: https://reviews.apache.org/r/6658/diff/
> 
> 
> Testing
> -------
> 
> Tested on Centos 6.2 x64
> Build RPMS via './waf rpm'          : passed
> Installed RPMS to management server : passed
> Installed RPMs to hypervisor host   : passed
> Started/stopped via init scripts    : passed
> Create zone, deploy instance        : passed
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message