incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitin Mehta" <nitin.me...@citrix.com>
Subject Re: Review Request: deployVirtualMachine api, added a check to see if the userdata provided is base64 encoded.
Date Tue, 07 Aug 2012 11:35:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6428/#review9953
-----------------------------------------------------------



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/6428/#comment21153>

    Can you please also write an english comment as to what the regular expression tries to
match ?



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/6428/#comment21152>

    It might be helpful if you pre-compile the pattern since its a constant and you wouldnt
be wasting time computing it on the fly and also since the mangers are singletons


- Nitin Mehta


On Aug. 7, 2012, 9:37 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6428/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 9:37 a.m.)
> 
> 
> Review request for cloudstack and Prachi Damle.
> 
> 
> Description
> -------
> 
> Error out with InvalidParameterValueException in UserVmManagerImpl if userdata is not
base64 encoded.
> 
> 
> This addresses bug CS-14796.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java f441c72 
> 
> Diff: https://reviews.apache.org/r/6428/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message