incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <Prasanna.Santha...@citrix.com>
Subject Review Request: CS-15833: PreparForMigrationCommand should extend base Command object
Date Fri, 03 Aug 2012 10:46:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6338/
-----------------------------------------------------------

Review request for cloudstack, Nitin Mehta, edison su, and Alex Huang.


Description
-------

Download original patch: http://patchbin.baagi.org/p?id=l7fzrl

The PrepareForMigrationCommand implemented by ServerResources wrongly implements StartCommand
used for starting a VM.


This addresses bug http://bugs.cloudstack.org/browse/CS-15833.


Diffs
-----

  api/src/com/cloud/agent/api/PrepareForMigrationCommand.java 866aaea 

Diff: https://reviews.apache.org/r/6338/diff/


Testing
-------

1) ant clean-all build-all
2) ant run-simulator
3) ant run-marvin
4) Deployed a few VMs and put the host into maintenance and cancel maintenance

Host successfully reaches Maintenance state and comes back out of maintenance.


Thanks,

Prasanna Santhanam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message