incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tomoe Sugihara" <to...@midokura.com>
Subject Review Request: POC VIF plugin implementation
Date Wed, 01 Aug 2012 16:42:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6285/
-----------------------------------------------------------

Review request for cloudstack and Chiradeep Vittal.


Description
-------

POC VIF plugin implementation
-----------------------------

- This allows vendors to implement their of plug/unplug logic, and users can choose one by
specifying "libvirt.vif.driver" parameter in agent.properties file.
  - if it is not specified, it defaults to the current implementation with Linux bridge.
- This work is still half way in that:
  - unplug hasn't been implemented
  - I was going to factor out the existing default implementation with Linux bridge to something
like LibvirtBridgeVifDriver, but there's a bunch of dependencies (on methods and fields in
LibvirtComputingResource and VirtualRoutingResource) and I couldn't finish it. Ultimately,
all the networking specific logic should be separated from LibvirtComputingResource to vif
driver.
 


Diffs
-----

  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
ea12b986b0a771c028354637a657b100fc3cfa27 

Diff: https://reviews.apache.org/r/6285/diff/


Testing
-------


Thanks,

Tomoe Sugihara


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message